Skip to content

puppet generate types breaks on 2.0.0+ #91

@asreich

Description

@asreich

Describe the Bug

This line is coming up in syntax errors when I run puppet generate types.

Error: Failed to load custom type 'cron' from '/etc/puppetlabs/code/environments/master/modules/cron_core/lib/puppet/type/cron.rb': /etc/puppetlabs/code/environments/master/modules/cron_core/lib/puppet/type/cron.rb:189: syntax error, unexpected ','
...t a valid %{name}') % { value:, name: self.class.name } unle...
...                              ^
/etc/puppetlabs/code/environments/master/modules/cron_core/lib/puppet/type/cron.rb:189: syntax error, unexpected '}', expecting keyword_end
...value:, name: self.class.name } unless retval
...                              ^
/etc/puppetlabs/code/environments/master/modules/cron_core/lib/puppet/type/cron.rb:190: Invalid return in class/module body
      return retval.to_s if retval
      ^~~~~~
/etc/puppetlabs/code/environments/master/modules/cron_core/lib/puppet/type/cron.rb:420: syntax error, unexpected '}'
...eld}') % ({ cron: ref, field: })
...                              ^
/etc/puppetlabs/code/environments/master/modules/cron_core/lib/puppet/type/cron.rb:469: syntax error, unexpected keyword_end, expecting ')'

Expected Behavior

puppet generate types does not error out

Steps to Reproduce

Steps to reproduce the behavior:

  1. Using cron_core via puppet-cron in Puppetfile results in no version pinning, picks newest compatible, version 2.0.1
  2. Run puppet generate types

Environment

PDK 2.7.1
pdk (INFO): Using Ruby 2.5.9
pdk (INFO): Using Puppet 6.29.0

Additional Context

EDIT: Some further Googling suggests this may be a Ruby issue, which I think means this means 2.0.0+ is no longer compatible with Puppet 6 like the Forge page says, which is probably why this broke.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions