fix: return undefined instead of null (#498)

* fix: return undefined instead of null

* chore: tidy up some ci workflows

Author: pure-js

.github/workflows/lint.yml

@@ -2,7 +2,6 @@ name: Code Linting
 
 on:
   push:
-  workflow_call:
 
 jobs:
   eslint:

.github/workflows/release-please.yml

@@ -1,15 +1,14 @@
+name: Release
+
 on:
   push:
     branches:
-      - master
       - main
 
 permissions:
   contents: write
   pull-requests: write
 
-name: release-please
-
 jobs:
   release-please:
     runs-on: ubuntu-latest

.github/workflows/test.yml

@@ -1,8 +1,10 @@
 name: Unit Testing
+
 on:
   push:
+
 jobs:
-  build:
+  unit-test:
     runs-on: ubuntu-latest
     strategy:
       matrix:

package.json

@@ -8,7 +8,8 @@
     "start": "vite",
     "build": "tsc && vite build",
     "lint": "eslint src/**/* --ext .ts",
-    "test": "vitest --coverage --run"
+    "test": "vitest --coverage --run",
+    "test:watch": "vitest --coverage"
   },
   "repository": {
     "type": "git",

src/browser-detection.test.ts

@@ -158,7 +158,7 @@ describe('Should work correctly', () => {
 
     expect(detectBrowserNameAndVersion(ieWithoutVersion)).toEqual({
       name: 'IE',
-      version: null,
+      version: undefined,
     });
   });
 
@@ -169,7 +169,7 @@ describe('Should work correctly', () => {
 
     expect(detectBrowserNameAndVersion(emptyUserAgent)).toEqual({
       name: undefined,
-      version: NaN,
+      version: undefined,
     });
   });
 });

src/browser-detection.ts

@@ -168,12 +168,12 @@ function detectBrowserVersion(nav: {userAgent: string}, name: string): number |
   switch (name) {
     case 'IE': {
       const temp = /\brv[ :]+(\d+)/g.exec(userAgent) ?? [];
-      return Number(temp[1]) || null;
+      return Number(temp[1]) || undefined;
     }
 
     case 'Edge': {
       const temp = /\b(Edge)\/(\d+)/.exec(userAgent);
-      return Number(temp[2]);
+      return temp ? Number(temp[2]) : undefined;
     }
   }
 
@@ -194,7 +194,7 @@ function detectBrowserVersion(nav: {userAgent: string}, name: string): number |
     found.splice(1, 1, temp[1]);
   }
 
-  return Number(found[1]);
+  return found[1] ? Number(found[1]) : undefined;
 }
 
 /**