Skip to content

Commit 4ac3e92

Browse files
committed
Don't export slice, take/drop are preferrable
1 parent 1636d06 commit 4ac3e92

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@
6565

6666
singleton :: forall a. a -> [a]
6767

68-
slice :: forall a. Prim.Number -> Prim.Number -> [a] -> [a]
69-
7068
snoc :: forall a. [a] -> a -> [a]
7169

7270
sort :: forall a. (Ord a) => [a] -> [a]

src/Data/Array.purs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ module Data.Array
1717
, reverse
1818
, drop
1919
, take
20-
, slice
2120
, insertAt
2221
, deleteAt
2322
, updateAt
@@ -130,12 +129,8 @@ foreign import drop
130129
\ };\
131130
\}" :: forall a. Number -> [a] -> [a]
132131

133-
foreign import take
134-
"function take (n) {\
135-
\ return function (l) {\
136-
\ return l.slice(0, n);\
137-
\ };\
138-
\}" :: forall a. Number -> [a] -> [a]
132+
take :: forall a. Number -> [a] -> [a]
133+
take n = slice 0 n
139134

140135
foreign import slice
141136
"function slice (s) {\

0 commit comments

Comments
 (0)