Skip to content

Commit 07a8f76

Browse files
committed
Merge pull request #53 from sharkdp/fix-drop
Handle negative arguments in drop, resolves #52
2 parents 9d4ef0c + 5ed4d40 commit 07a8f76

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/Data/String.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ exports.take = function (n) {
122122

123123
exports.drop = function (n) {
124124
return function (s) {
125-
return s.substr(n);
125+
return s.substring(n);
126126
};
127127
};
128128

test/Test/Data/String.purs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,12 +128,14 @@ testString = do
128128
assert $ take 1 "ab" == "a"
129129
assert $ take 2 "ab" == "ab"
130130
assert $ take 3 "ab" == "ab"
131+
assert $ take (-1) "ab" == ""
131132

132133
log "drop"
133134
assert $ drop 0 "ab" == "ab"
134135
assert $ drop 1 "ab" == "b"
135136
assert $ drop 2 "ab" == ""
136137
assert $ drop 3 "ab" == ""
138+
assert $ drop (-1) "ab" == "ab"
137139

138140
log "count"
139141
assert $ count (\c -> true) "" == 0

0 commit comments

Comments
 (0)