Fix recipient count double counting failures

Author: bencroker

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release Notes for Campaign
 
+## 3.8.2 - Unreleased
+
+- Fixed a bug in which the number of recipients could be lower than expected when send failures occur ([#547](https://github.com/putyourlightson/craft-campaign/issues/547)).
+
 ## 3.8.1 - 2025-12-23
 
 - Fixed a bug in which campaigns could not be closed ([#539](https://github.com/putyourlightson/craft-campaign/issues/539)).

composer.json

@@ -1,7 +1,7 @@
 {
   "name": "putyourlightson/craft-campaign",
   "description": "Send and manage email campaigns, contacts and mailing lists.",
-  "version": "3.8.1",
+  "version": "3.8.2",
   "type": "craft-plugin",
   "homepage": "https://putyourlightson.com/plugins/campaign",
   "license": "proprietary",

src/services/SendoutsService.php

@@ -116,19 +116,17 @@ public function getPendingRecipients(SendoutElement $sendout, int $limit = null)
     }
 
     /**
-     * Returns the number of pending recipients, not including failed attempts.
+     * Returns the number of pending recipients.
      */
     public function getPendingRecipientCount(SendoutElement $sendout): int
     {
         if ($sendout->sendoutType === 'regular' || $sendout->sendoutType === 'scheduled') {
-            $count = ContactElement::find()
+            return ContactElement::find()
                 ->id($this->getPendingRecipientsStandardIds($sendout))
                 ->count();
-        } else {
-            $count = count($this->getPendingRecipients($sendout));
         }
 
-        return $count - $sendout->failures;
+        return count($this->getPendingRecipients($sendout));
     }
 
     /**