Skip to content

Commit ac5aec8

Browse files
committed
Removed unused references to old app image gen
1 parent 4a1befc commit ac5aec8

File tree

10 files changed

+8
-160
lines changed

10 files changed

+8
-160
lines changed

.github/ISSUE_TEMPLATE/new-release-internal.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ body:
4040
4141
#### PWABuilder.com existing functionality tests
4242
- [ ] Test /portals and ensure is working (linked to from PowerApps)
43-
- [ ] Test /imageGenerator and ensure is working (linked to from dev tools)
4443
- [ ] Accessibility Pass has been run (Using Accessibility Insights Tool)
4544
4645
#### Design

apps/pwabuilder/Controllers/ImagesController.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,18 +80,18 @@ public async Task<IActionResult> GetSafeImageForAnalysis([FromQuery] string anal
8080
[HttpPost("generateStoreImages")]
8181
[RequestFormLimits(MultipartBodyLengthLimit = 5 * 1024 * 1024)]
8282
[RequestSizeLimit(5 * 1024 * 1024)]
83-
public async Task<IActionResult> GenerateStoreImages([FromForm] StoreImageCreationOptions request, [FromServices] StoreImageCreator imageGenerator, CancellationToken cancelToken)
83+
public async Task<IActionResult> GenerateStoreImages([FromForm] StoreImageCreationOptions request, [FromServices] StoreImageCreator storeImageCreator, CancellationToken cancelToken)
8484
{
8585
try
8686
{
8787
using var baseImageStream = request.BaseImage.OpenReadStream();
88-
var storeImagesZipStream = await imageGenerator.CreateStoreImagesZipAsync(baseImageStream, request.BaseImage.ContentType, request.Padding, request.BackgroundColor, request.Platforms, cancelToken);
88+
var storeImagesZipStream = await storeImageCreator.CreateStoreImagesZipAsync(baseImageStream, request.BaseImage.ContentType, request.Padding, request.BackgroundColor, request.Platforms, cancelToken);
8989
return File(storeImagesZipStream, "application/zip", "appstore-images.zip");
9090
}
91-
catch (Exception imageGeneratorError)
91+
catch (Exception imageCreationError)
9292
{
93-
logger.LogError(imageGeneratorError, "Error generating store images for image of size {size} for {platforms} with padding {padding} and color {color}.", request.BaseImage.Length, string.Join(", ", request.Platforms), request.Padding, request.BackgroundColor);
94-
return StatusCode(500, $"An error occurred while generating store images: {imageGeneratorError.Message}");
93+
logger.LogError(imageCreationError, "Error generating store images for image of size {size} for {platforms} with padding {padding} and color {color}.", request.BaseImage.Length, string.Join(", ", request.Platforms), request.Padding, request.BackgroundColor);
94+
return StatusCode(500, $"An error occurred while generating store images: {imageCreationError.Message}");
9595
}
9696
}
9797

apps/pwabuilder/Frontend/src/script/services/icon_generator.ts

Lines changed: 0 additions & 124 deletions
This file was deleted.

apps/pwabuilder/Frontend/src/script/utils/api.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

apps/pwabuilder/Frontend/src/script/utils/environment.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ export const env = {
66
windowsPackageGeneratorUrl: '',
77
androidPackageGeneratorUrl: '',
88
iosPackageGeneratorUrl: '',
9-
oculusPackageGeneratorUrl: '',
10-
imageGeneratorUrl: '',
119
safeUrlFetcher: '',
1210
validateGiveawayUrl: '',
1311
tokensCampaignRunning: false,
@@ -25,10 +23,6 @@ if (import.meta.env.PROD) {
2523
env.androidPackageGeneratorUrl =
2624
'https://pwabuilder-cloudapk.azurewebsites.net';
2725
env.iosPackageGeneratorUrl = '/api/iospackage/create';
28-
env.oculusPackageGeneratorUrl =
29-
'https://pwabuilder-oculus-linux-docker-app.azurewebsites.net/packages/create';
30-
env.imageGeneratorUrl =
31-
'https://appimagegenerator-prod.azurewebsites.net';
3226
env.safeUrlFetcher =
3327
'/api/images/getSafeImageForAnalysis';
3428
env.validateGiveawayUrl =
@@ -43,10 +37,6 @@ if (import.meta.env.PROD) {
4337
env.androidPackageGeneratorUrl =
4438
'http://localhost:5858';
4539
env.iosPackageGeneratorUrl = '/api/iospackage/create';
46-
env.oculusPackageGeneratorUrl =
47-
'https://pwabuilder-oculus-linux-docker-app.azurewebsites.net/packages/create';
48-
env.imageGeneratorUrl =
49-
'https://appimagegenerator-prod.azurewebsites.net';
5040
env.safeUrlFetcher =
5141
'/api/images/getSafeImageForAnalysis';
5242
env.validateGiveawayUrl =

apps/pwabuilder/Models/AppSettings.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ public class AppSettings
44
{
55
public string IOSSourceCodePath { get; set; } = string.Empty;
66
public string NextStepsPath { get; set; } = string.Empty;
7-
public string ImageGeneratorApiUrl { get; set; } = string.Empty;
87
public string AnalyticsUrl { get; set; } = string.Empty;
98
public string ApplicationInsightsConnectionString { get; set; } = string.Empty;
109
public string AzureManagedIdentityApplicationId { get; set; } = string.Empty;

apps/pwabuilder/appsettings.Development.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"AnalyticsUrl": "",
1010
"ApplicationInsightsConnectionString": "",
1111
"IOSSourceCodePath": "bin/Debug/net10.0/Resources/IOS/ios-project-src",
12-
"NextStepsPath": "bin/Debug/net10.0/Resources/IOS/ios-next-steps.html",
13-
"ImageGeneratorApiUrl": "/api/images/generateStoreImages"
12+
"NextStepsPath": "bin/Debug/net10.0/Resources/IOS/ios-next-steps.html"
1413
}
1514
}

apps/pwabuilder/appsettings.Production.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"AnalyticsUrl": "",
44
"ApplicationInsightsConnectionString": "",
55
"IOSSourceCodePath": "Resources/IOS/ios-project-src",
6-
"NextStepsPath": "Resources/IOS/ios-next-steps.html",
7-
"ImageGeneratorApiUrl": "https://pwabuilder.com/api/images/generateStoreImages"
6+
"NextStepsPath": "Resources/IOS/ios-next-steps.html"
87
}
98
}

apps/pwabuilder/appsettings.Staging.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"AnalyticsUrl": "",
44
"ApplicationInsightsConnectionString": "",
55
"IOSSourceCodePath": "Resources/IOS/ios-project-src",
6-
"NextStepsPath": "Resources/IOS/ios-next-steps.html",
7-
"ImageGeneratorApiUrl": "https://appimagegenerator-prod.azurewebsites.net/api/image"
6+
"NextStepsPath": "Resources/IOS/ios-next-steps.html"
87
}
98
}

apps/pwabuilder/appsettings.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"ApplicationInsightsConnectionString": "",
1111
"IOSSourceCodePath": "",
1212
"NextStepsPath": "",
13-
"ImageGeneratorApiUrl": "",
1413
"AzureRedisHost": "",
1514
"AzureManagedIdentityApplicationId": "",
1615
"AzureStorageAccountName": "",

0 commit comments

Comments
 (0)