Skip to content

fix: remove flush() in _write_frame to prevent hang on USB CDC ACM #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jirogit wants to merge 1 commit into from
+3 −5
Closed

fix: remove flush() in _write_frame to prevent hang on USB CDC ACM #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/pymc_core/hardware/kiss_modem_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,11 +456,9 @@ def _write_frame(self, frame: bytes) -> bool:
except Exception as e:
logger.error("Serial write error: %s", e)
return False
try:
self.serial_conn.flush()
except Exception as e:
logger.error("Serial flush error: %s", e)
return False
# flush()/tcdrain() removed: hangs indefinitely on USB CDC ACM
# (e.g. ESP32 T3S3/S3 with TinyUSB). write() already copies data
# to the kernel USB buffer atomically; no drain needed.
return True

def _set_kiss_tx_delay(self, delay_ms: int) -> None:
Expand Down