Prohibited name flow tweaks (#12549)

* List releases by date in prohibited name flow

* Add click-to-copy in prohibited names flow

Author: di

tests/unit/admin/views/test_prohibited_project_names.py

@@ -12,6 +12,8 @@
 
 import uuid
 
+from collections import defaultdict
+
 import pretend
 import pytest
 
@@ -101,17 +103,36 @@ def test_nothing_to_delete(self, db_request):
 
         assert result == {
             "prohibited_project_names": {"project": "foo", "comment": ""},
-            "existing": {"project": None, "releases": [], "files": [], "roles": []},
+            "existing": {
+                "project": None,
+                "releases": [],
+                "files": [],
+                "roles": [],
+                "releases_by_date": defaultdict(list),
+            },
         }
 
     def test_stuff_to_delete(self, db_request):
+        db_request.user = UserFactory.create()
         project = ProjectFactory.create()
+        release = ReleaseFactory.create(project=project)
+        file_ = FileFactory.create(release=release, filename="who cares")
+        role = RoleFactory.create(project=project, user=db_request.user)
+
         db_request.GET["project"] = project.name
         result = views.confirm_prohibited_project_names(db_request)
 
         assert result == {
             "prohibited_project_names": {"project": project.name, "comment": ""},
-            "existing": {"project": project, "releases": [], "files": [], "roles": []},
+            "existing": {
+                "project": project,
+                "releases": [release],
+                "files": [file_],
+                "roles": [role],
+                "releases_by_date": defaultdict(
+                    list, {release.created.strftime("%Y-%m-%d"): [release]}
+                ),
+            },
         }
 
 

warehouse/admin/static/js/warehouse.js

@@ -11,6 +11,13 @@
  * limitations under the License.
  */
 
+// We'll use docReady as a modern replacement for $(document).ready() which
+// does not require all of jQuery to use. This will let us use it without
+// having to load all of jQuery, which will make things faster.
+import docReady from "warehouse/utils/doc-ready";
+
+import Clipboard from "clipboard";
+
 document.querySelectorAll("a[data-form-submit]").forEach(function (element) {
   element.addEventListener("click", function(event) {
     // We're turning this element into a form submission, so instead of the
@@ -74,3 +81,38 @@ document.querySelectorAll(".btn-group[data-input][data-state]").forEach(function
     });
   });
 });
+
+// Copy handler for copy tooltips, e.g.
+//   - the pip command on package detail page
+//   - the copy hash on package detail page
+//   - the copy hash on release maintainers page
+//
+// Copied from https://github.com/pypi/warehouse/blob/3ebae1ffe8f9f258f80eb8bf048f0e1fcc2df2b4/warehouse/static/js/warehouse/index.js#LL76-L107C4
+docReady(() => {
+  let setCopiedTooltip = (e) => {
+    e.trigger.setAttribute("data-tooltip-label", "Copied");
+    e.trigger.setAttribute("role", "alert");
+    e.clearSelection();
+  };
+
+  new Clipboard(".copy-tooltip").on("success", setCopiedTooltip);
+
+  let setOriginalLabel = (element) => {
+    element.setAttribute("data-tooltip-label", "Copy to clipboard");
+    element.removeAttribute("role");
+    element.blur();
+  };
+
+  let tooltippedElems = Array.from(document.querySelectorAll(".copy-tooltip"));
+
+  tooltippedElems.forEach((element) => {
+    element.addEventListener("focusout",
+      setOriginalLabel.bind(undefined, element),
+      false
+    );
+    element.addEventListener("mouseout",
+      setOriginalLabel.bind(undefined, element),
+      false
+    );
+  });
+});

warehouse/admin/templates/admin/prohibited_project_names/confirm.html

@@ -30,11 +30,22 @@
               <p>
                 Prohibiting {{ prohibited_project_names.project }} will irreversibly delete
                 the <a href="{{ request.route_path('admin.project.detail', project_name=existing.project.normalized_name) }}">{{ existing.project.name }}</a>
-                project along with
-                <a href="{{ request.route_path('admin.project.releases', project_name=existing.project.normalized_name) }}">{{ existing.releases|length() }} releases</a>
-                and {{ existing.files|length() }} files. This project has
-                {{ existing.users|length() }} users able to access it, listed
-                below:
+                project along with the following
+                <a href="{{ request.route_path('admin.project.releases', project_name=existing.project.normalized_name) }}">{{ existing.releases|length() }} releases</a>:
+
+                <ul>
+                  {% for date, releases in existing.releases_by_date|dictsort(reverse=True) %}
+                  <li>
+                    {{ date }} -
+                    {% for release in releases %}
+                    <a href="{{ request.route_path('admin.project.release', project_name=release.project.normalized_name, version=release.version) }}">{{ release.version }}</a>{% if not loop.last %}, {% endif %}
+                    {% endfor %}
+                  </li>
+                  {% endfor %}
+                </ul>
+
+                This project has {{ existing.roles|length }} users able to
+                access it, listed below:
 
                 <ul>
                   {% for role in existing.roles %}
@@ -51,7 +62,11 @@
 
               <p>
                 Are you sure you want to prohibit
-                <strong>{{ prohibited_project_names.project }}</strong>?
+                <code id="project-name">{{ prohibited_project_names.project }}</code>
+                <button type="button" class="copy-tooltip copy-tooltip-s" data-clipboard-target="#project-name" data-tooltip-label="Copy to clipboard">
+                  <i class="fa fa-copy" aria-hidden="true"></i>
+                </button>
+                ?
               </p>
 
               <form action="{{ request.current_route_path() }}" method="POST">

warehouse/admin/views/prohibited_project_names.py

@@ -12,6 +12,8 @@
 
 import shlex
 
+from collections import defaultdict
+
 from packaging.utils import canonicalize_name
 from paginate_sqlalchemy import SqlalchemyOrmPage as SQLAlchemyORMPage
 from pyramid.httpexceptions import HTTPBadRequest, HTTPNotFound, HTTPSeeOther
@@ -125,11 +127,16 @@ def confirm_prohibited_project_names(request):
         files = []
         roles = []
 
+    releases_by_date = defaultdict(list)
+    for release in releases:
+        releases_by_date[release.created.strftime("%Y-%m-%d")].append(release)
+
     return {
         "prohibited_project_names": {"project": project_name, "comment": comment},
         "existing": {
             "project": project,
             "releases": releases,
+            "releases_by_date": releases_by_date,
             "files": files,
             "roles": roles,
         },