reimplementSpatialImplicit measures with Graph

[knaaptime]

this will be a major improvement but a major change. Currently SpatialImplicit indices can accept either a W or a pandana.Network (which have different arguments). It's very easy to make a pandana-backed Graph, so these will now only accept Graphs. The first step is wrapping the network-->graph logic into a little utility function. That could live in lib, like the xarray builder, but also might make sense to move more of the network stuff into spopt. Any thoughts @jGaboardi @martinfleis

[jGaboardi]

I really need to decide what to do with spaghetti... It has been languishing for years now¹² , but I haven't had the time or mental space to figure out what to do with it. Ideally, all network-type stuff would happen in 1 package, but I'm not sure how feasible that would be without a major overhaul to several packages....

---

Footnotes

1. https://github.com/pysal/spaghetti/discussions/195 ↩

2. https://github.com/pysal/spaghetti/discussions/403 ↩

[jGaboardi]

re: moving stuff to spopt -- I don't think that's the right place.

[martinfleis]

I would keep it among other builders in lib. I would consume it in momepy and I think that having all builders on the Graph would greatly improve their visibility.

If you want all network stuff in one package, keep in mind we also have access.

[knaaptime]

agree a weights builder would make sense in lib. My thought was it would be useful to have some other network utilities like these somewhere in the pysal stack (especially for tests and such if a builder will live in lib). And anything backed by pandana feels fundamentally like routing; despite its description (regionalization, optimization, routing), spopt doesn't have any routing (I think?). (though now that I'm looking closer, I see 'routing' has been replaced by 'transportation-oriented solutions' :P)

[martinfleis]

We also have (some) analogous functions interfacing networkx in momepy.

[knaaptime]

i need to play with momepy again... those are cool!

i'd be happy to send those utils to momepy if that's best, though they don't feel particular morphometric. I hate to propose a new package, but would it make sense to think about a successor to spaghetti that consolidates some of this stuff (and maybe provides a path forward for you to pick and choose what you want to keep from before james?). Not sure that's an ideal path, just a thought

[martinfleis]

i'd be happy to send those utils to momepy if that's best

I am not sure about that, just wanted to flag that the pandana stuff is not the only one to consider.

[knaaptime]

this migration should also include a move to pandarm and deprecate pandana

[martinfleis]

I didn't know you actually forked pandana. Cool!

[knaaptime]

a couple days fighting infuriating and opaque c++ errors--a new adventure--but well worth it in the end, i think. AFAICT, have just about everything working properly, even the wheel builds for pypi. Just need to rewrite the old tests

[jGaboardi]

Just need to rewrite the old tests

I can try to carve out some time to assist with this in the coming weeks.