flake8 -> ruff

Author: Julian

.pre-commit-config.yaml

@@ -14,22 +14,14 @@ repos:
       - id: mixed-line-ending
         args: [--fix, lf]
       - id: trailing-whitespace
+  - repo: https://github.com/charliermarsh/ruff-pre-commit
+    rev: "v0.0.270"
+    hooks:
+      - id: ruff
   - repo: https://github.com/PyCQA/isort
     rev: 5.12.0
     hooks:
       - id: isort
-  - repo: https://github.com/PyCQA/flake8
-    rev: "6.0.0"
-    hooks:
-      - id: flake8
-  - repo: https://github.com/asottile/yesqa
-    rev: v1.4.0
-    hooks:
-      - id: yesqa
-  - repo: https://github.com/asottile/pyupgrade
-    rev: v3.4.0
-    hooks:
-      - id: pyupgrade
   - repo: https://github.com/psf/black
     rev: 23.3.0
     hooks:

jsonschema_specifications/__init__.py

@@ -1,3 +1,6 @@
+"""
+The JSON Schema meta-schemas and vocabularies, exposed as a Registry.
+"""
 from referencing import Registry as _Registry
 from referencing.jsonschema import SchemaRegistry as _SchemaRegistry
 

jsonschema_specifications/_core.py

@@ -16,7 +16,6 @@ def _schemas():
     """
     All schemas we ship.
     """
-
     # importlib.resources.abc.Traversal doesn't have nice ways to do this that
     # I'm aware of...
     #

jsonschema_specifications/tests/test_jsonschema_specifications.py

@@ -1,7 +1,10 @@
+from collections.abc import Mapping
+
 from jsonschema_specifications import REGISTRY
 
 
 def test_it_contains_metaschemas():
     schema = REGISTRY.contents("http://json-schema.org/draft-07/schema#")
+    assert isinstance(schema, Mapping)
     assert schema["$id"] == "http://json-schema.org/draft-07/schema#"
     assert schema["title"] == "Core schema meta-schema"

noxfile.py

@@ -26,6 +26,12 @@ def tests(session):
     session.run("pytest", "--verbosity=3")
 
 
+@session()
+def audit(session):
+    session.install("pip-audit", ROOT)
+    session.run("python", "-m", "pip_audit")
+
+
 @session(tags=["build"])
 def build(session):
     session.install("build")
@@ -43,15 +49,8 @@ def readme(session):
 
 @session(tags=["style"])
 def style(session):
-    session.install(
-        "flake8",
-        "flake8-broken-line",
-        "flake8-bugbear",
-        "flake8-commas",
-        "flake8-quotes",
-        "flake8-tidy-imports",
-    )
-    session.run("python", "-m", "flake8", PACKAGE, __file__)
+    session.install("ruff")
+    session.run("ruff", "check", ROOT)
 
 
 @session()

pyproject.toml

@@ -49,13 +49,23 @@ Issues = "https://github.com/python-jsonschema/jsonschema-specifications/issues/
 Funding = "https://github.com/sponsors/Julian"
 Source = "https://github.com/python-jsonschema/jsonschema-specifications"
 
+[tool.coverage.html]
+show_contexts = true
+skip_covered = false
+
 [tool.coverage.run]
 branch = true
 source = ["jsonschema-specifications"]
 dynamic_context = "test_function"
 
 [tool.coverage.report]
+exclude_also = [
+  "if TYPE_CHECKING:",
+  "\\s*\\.\\.\\.\\s*",
+]
 fail_under = 100
+show_missing = true
+skip_covered = true
 
 [tool.doc8]
 ignore = [
@@ -68,3 +78,46 @@ ensure_newline_before_comments = true
 from_first = true
 include_trailing_comma = true
 multi_line_output = 3
+
+[tool.ruff]
+line-length = 79
+target-version = "py38"
+select = ["ANN", "B", "D", "E", "F", "Q", "UP", "W"]
+ignore = [
+  # Wat, type annotations for self and cls, why is this a thing?
+  "ANN101",
+  "ANN102",
+  # Private annotations are fine to leave out.
+  "ANN202",
+  # I don't know how to more properly annotate "pass along all arguments".
+  "ANN401",
+  # raise SomeException(...) is fine.
+  "B904",
+  # It's fine to not have docstrings for magic methods.
+  "D105",
+  # This rule makes diffs uglier when expanding docstrings (and it's uglier)
+  "D200",
+  # No blank lines before docstrings.
+  "D203",
+  # Start docstrings on the second line.
+  "D212",
+  # This rule misses sassy docstrings ending with ! or ?.
+  "D400",
+  # Section headers should end with a colon not a newline
+  "D406",
+  # Underlines aren't needed
+  "D407",
+  # Plz spaces after section headers
+  "D412",
+  # We support 3.8 + 3.9
+  "UP007",
+]
+extend-exclude = ["suite"]
+
+[tool.ruff.flake8-quotes]
+docstring-quotes = "double"
+
+[tool.ruff.per-file-ignores]
+"docs/*" = ["ANN", "D"]
+"jsonschema_specifications/tests/*" = ["ANN", "D"]
+"noxfile.py" = ["ANN", "D"]