Merge pull request #85 from p1c2u/feature/collection-validation

Collection validation

Author: p1c2u

openapi_core/schema/schemas/models.py

@@ -243,6 +243,7 @@ def _unmarshal_properties(self, value, one_of_schema=None):
 
     def get_validator_mapping(self):
         mapping = {
+            SchemaType.ARRAY: self._validate_collection,
             SchemaType.OBJECT: self._validate_object,
         }
 
@@ -270,6 +271,12 @@ def validate(self, value):
 
         return value
 
+    def _validate_collection(self, value):
+        if self.items is None:
+            raise OpenAPISchemaError("Schema for collection not defined")
+
+        return list(map(self.items.validate, value))
+
     def _validate_object(self, value):
         properties = value.__dict__
 

tests/unit/schema/test_schemas.py

@@ -5,7 +5,7 @@
 
 from openapi_core.extensions.models.models import Model
 from openapi_core.schema.schemas.exceptions import (
-    InvalidSchemaValue, MultipleOneOfSchema, NoOneOfSchema,
+    InvalidSchemaValue, MultipleOneOfSchema, NoOneOfSchema, OpenAPISchemaError,
 )
 from openapi_core.schema.schemas.models import Schema
 
@@ -199,9 +199,16 @@ def test_boolean_invalid(self, value):
             schema.validate(value)
 
     @pytest.mark.parametrize('value', [[1, 2], (3, 4)])
-    def test_array(self, value):
+    def test_array_no_schema(self, value):
         schema = Schema('array')
 
+        with pytest.raises(OpenAPISchemaError):
+            schema.validate(value)
+
+    @pytest.mark.parametrize('value', [[1, 2], (3, 4)])
+    def test_array(self, value):
+        schema = Schema('array', items=Schema('integer'))
+
         result = schema.validate(value)
 
         assert result == value