Skip to content

Commit af44bd0

Browse files
committed
Add explanation for direct_assign.py failing test
1 parent 1239d1c commit af44bd0

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

tests/failing_tests/direct_assign.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,18 @@
44

55
from ctypes import c_void_p, c_int64
66

7+
# NOTE: I have decided to not fix this example for now.
8+
# The issue is in line 31, where we are passing an expression.
9+
# The update helper expects a pointer type. But the problem is
10+
# that we must allocate the space for said pointer in the first
11+
# basic block. As that usage is in a different basic block, we
12+
# are unable to cast the expression to a pointer type. (as we never
13+
# allocated space for it).
14+
# Shall we change our space allocation logic? That allows users to
15+
# spam the same helper with the same args, and still run out of
16+
# stack space. So we consider this usage invalid for now.
17+
# Might fix it later.
18+
719

820
@bpf
921
@map

0 commit comments

Comments
 (0)