Store conference in the privacy policy acceptance record model (#4099)

Author: marcoacierno

backend/api/orders/mutations.py

@@ -61,7 +61,9 @@ def create_order(
         except PretixError as e:
             return CreateOrderErrors.with_error("non_field_errors", str(e))
 
-        record_privacy_policy_acceptance(info.context.request, "checkout-order")
+        record_privacy_policy_acceptance(
+            info.context.request, conference_obj, "checkout-order"
+        )
 
         return_url = urljoin(
             settings.FRONTEND_URL,

backend/api/tests/schema/test_create_order.py

@@ -160,7 +160,7 @@ def test_calls_create_order(graphql_client, user, mocker):
     assert billing_address.fiscal_code == "GNLNCH22T27L523A"
 
     assert PrivacyPolicyAcceptanceRecord.objects.filter(
-        user=user, privacy_policy="checkout-order"
+        user=user, conference=conference, privacy_policy="checkout-order"
     ).exists()
 
 

backend/privacy_policy/migrations/0002_privacypolicyacceptancerecord_conference.py

@@ -0,0 +1,21 @@
+# Generated by Django 5.1.1 on 2024-10-02 10:56
+
+import django.db.models.deletion
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('conferences', '0047_alter_conferencevoucher_options_and_more'),
+        ('privacy_policy', '0001_initial'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='privacypolicyacceptancerecord',
+            name='conference',
+            field=models.ForeignKey(default=None, on_delete=django.db.models.deletion.PROTECT, to='conferences.conference'),
+            preserve_default=False,
+        ),
+    ]

backend/privacy_policy/models.py

@@ -2,6 +2,7 @@
 
 
 class PrivacyPolicyAcceptanceRecord(models.Model):
+    conference = models.ForeignKey("conferences.Conference", on_delete=models.PROTECT)
     user = models.ForeignKey("users.User", on_delete=models.PROTECT)
     accepted_at = models.DateTimeField(auto_now_add=True)
     ip_address = models.GenericIPAddressField()

backend/privacy_policy/record.py

@@ -1,17 +1,19 @@
 from django.http.request import HttpRequest
 from api.utils import get_ip
+from conferences.models.conference import Conference
 from privacy_policy.models import PrivacyPolicyAcceptanceRecord
 
 
 def record_privacy_policy_acceptance(
-    request: HttpRequest, privacy_policy: str
+    request: HttpRequest, conference: Conference, privacy_policy: str
 ) -> PrivacyPolicyAcceptanceRecord:
     user = request.user
     ip = get_ip(request)
     user_agent = request.headers.get("User-Agent", "")
 
     return PrivacyPolicyAcceptanceRecord.objects.create(
         user=user,
+        conference=conference,
         ip_address=ip,
         user_agent=user_agent,
         privacy_policy=privacy_policy,

backend/privacy_policy/tests/test_record.py

@@ -1,3 +1,4 @@
+from conferences.tests.factories import ConferenceFactory
 import time_machine
 from django.utils import timezone
 
@@ -6,6 +7,8 @@
 
 
 def test_record_privacy_policy_acceptance(rf):
+    conference = ConferenceFactory()
+
     request = rf.get("/")
     request.user = UserFactory(username="testuser", password="testpassword")
     request.headers = {
@@ -16,9 +19,12 @@ def test_record_privacy_policy_acceptance(rf):
     accepted_at = timezone.now()
 
     with time_machine.travel(accepted_at, tick=False):
-        record = record_privacy_policy_acceptance(request, "test-privacy-policy")
+        record = record_privacy_policy_acceptance(
+            request, conference, "test-privacy-policy"
+        )
 
     assert record.user_id == request.user.id
+    assert record.conference_id == conference.id
     assert record.accepted_at == accepted_at
     assert record.ip_address == "192.168.0.1"
     assert record.user_agent == "Test User Agent"