Fix Sponsor lead email sent check (#4272)

Author: marcoacierno

backend/api/sponsors/schema.py

@@ -71,13 +71,16 @@ def send_sponsor_lead(
         if errors := input.validate():
             return errors
 
-        is_new_email = not SponsorLead.objects.filter(email=input.email).exists()
         conference_id = (
             Conference.objects.filter(code=input.conference_code)
             .values_list("id", flat=True)
             .first()
         )
 
+        is_new_email = not SponsorLead.objects.filter(
+            conference_id=conference_id, email=input.email
+        ).exists()
+
         sponsor_lead, created = SponsorLead.objects.update_or_create(
             fullname=input.fullname,
             email=input.email,

backend/api/sponsors/tests/test_send_sponsor_lead.py

@@ -68,6 +68,45 @@ def test_send_sponsor_lead(graphql_client, consent_to_contact_via_email, mocker)
     )
 
 
+def test_send_sponsor_lead_works_if_email_was_sent_to_different_conf(
+    graphql_client, mocker
+):
+    mock_send_brochure = mocker.patch("api.sponsors.schema.send_sponsor_brochure")
+    mock_notify_new_sponsor_lead_via_slack = mocker.patch(
+        "api.sponsors.schema.notify_new_sponsor_lead_via_slack"
+    )
+
+    SponsorLeadFactory(
+        fullname="Tester",
+        email="[email protected]",
+        company="Example",
+        conference=ConferenceFactory(),
+        consent_to_contact_via_email=False,
+        brochure_viewed=False,
+    )
+
+    conference = ConferenceFactory()
+
+    resp = _send_sponsor_lead(
+        graphql_client,
+        input={
+            "fullname": "Tester",
+            "email": "[email protected]",
+            "company": "Example",
+            "conferenceCode": conference.code,
+            "consentToContactViaEmail": True,
+        },
+    )
+
+    assert not resp.get("errors")
+    assert resp["data"]["sendSponsorLead"]["__typename"] == "OperationResult"
+    assert resp["data"]["sendSponsorLead"]["ok"] is True
+
+    assert SponsorLead.objects.count() == 2
+    mock_send_brochure.delay.assert_called()
+    mock_notify_new_sponsor_lead_via_slack.delay.assert_called()
+
+
 def test_send_sponsor_lead_only_sends_the_brochure_once_to_email(
     graphql_client, mocker
 ):