Change rules to prefer top-level type markers (#9)

To be able to leverage `verbatimModuleSyntax` without errors or
workarounds, we need to switch to top-level `type` markers instead of
inline markers. See examples
[here](https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/consistent-type-specifier-style.md#examples).

This will ensure that TypeScript does not try to load modules from which
only types are imported, which will make it faster during build-time.
It's also a prerequisite to running TypeScript with Node directly, which
we may or may not do but would like the option to try.

Notes:
- It sounds like we should eventually remove the
`@typescript-eslint/consistent-type-imports` rule entirely based on
[this
recommendation](https://typescript-eslint.io/rules/consistent-type-imports/#comparison-with-importsnotusedasvalues--verbatimmodulesyntax).
But I thought it best to leave it there until we complete the transition
in the `platform` repo, or until we notice it causing conflicts.
- My preferred rule would be "top-level if only type imports, otherwise
inline" but I did not find any such rule. If others care deeply about
this, we could attempt to create it.

This would be released as a major/breaking change.

Author: aldeed

package-lock.json

@@ -7,7 +7,7 @@
     "@typescript-eslint/utils": "^8.29.1",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-github": "^5.1.8",
-    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-import": "github:qawolf/eslint-plugin-import#prefer-top-level-if-only-type-imports",
     "eslint-plugin-jest": "^28.11.0",
     "eslint-plugin-n": "^17.18.0",
     "eslint-plugin-perfectionist": "^4.11.0",

package.json

@@ -9,13 +9,16 @@ export const formattingRules = {
   // Also see import/consistent-type-specifier-style: they do similar, but slightly different things
   "@typescript-eslint/consistent-type-imports": [
     "error",
-    { fixStyle: "inline-type-imports" },
+    { fixStyle: "separate-type-imports" },
   ],
 
   curly: ["error", "multi-or-nest"],
 
   // Also see @typescript-eslint/consistent-type-imports: they do similar, but slightly different things
-  "import/consistent-type-specifier-style": ["error", "prefer-inline"],
+  "import/consistent-type-specifier-style": [
+    "error",
+    "prefer-top-level-if-only-type-imports",
+  ],
 
   "object-shorthand": ["error", "always", { avoidExplicitReturnArrows: true }],