Merge pull request #80 from quantori/fixing-minor-issues

Various changes and fixes

Author: SergeyRuzin

Behavioral.Automation.DemoScenarios/Features/ExampleBinding.feature

@@ -0,0 +1,7 @@
+Feature: ExampleBinding
+
+@Automated
+Scenario: Open Google page
+	When user opens URL "https://www.google.com/"
+	Then page title should become "Google"
+	

src/App/package-lock.json

@@ -26,8 +26,9 @@ public void CheckElementIsDisabled(
             [NotNull] AssertionBehavior behavior, 
             bool enabled)
         {
+            var status = enabled ? " not" : string.Empty;
             Assert.ShouldBecome(() => element.Enabled, enabled, behavior,
-                $"{element.Caption} is{behavior.BehaviorAppendix()} enabled");
+                $"{element.Caption} is{status} enabled");
         }
 
         [StepArgumentTransformation("(enabled|disabled)")]

src/Behavioral.Automation/Bindings/AttributeBinding.cs

@@ -116,7 +116,9 @@ private void CheckDropdownValueCollectionEnabled([NotNull] string behavior,
         {
             foreach (var row in table.Rows)
             {
-                runnerAction($"the \"{row.Values.First()} \" value {behavior} {enabled} in {wrapper.Caption}:");
+                Assert.ShouldBecome(() => row.Values.Any(), true, new AssertionBehavior(AssertionType.Immediate, false),
+                    "One of the rows in the provided table doesn't have values");
+                runnerAction($"the \"{row.Values.First()}\" value {behavior} {enabled} in {wrapper.Caption}");
             }
         }
 

src/Behavioral.Automation/Bindings/DropdownBinding.cs

@@ -33,15 +33,15 @@ public void CheckTableHaveRows(ITableWrapper gridRows, string behavior, Table ta
                 Assert.ShouldBecome(() => gridRows.Rows.ToStringRows().DoesntContainValues(table.Rows.ToStringRows()),
                     true,
                     new AssertionBehavior(AssertionType.Immediate, true),
-                    $"{gridRows.Caption} is {gridRows.Rows.GetPrintableValues()}");
+                    $"{gridRows.Caption} is: {gridRows.Rows.GetPrintableValues()}");
             }
             else
             {
 
                 Assert.ShouldBecome(() => gridRows.Rows.ToStringRows().HaveValues(table.Rows.ToStringRows(), false),
                     true,
                     new AssertionBehavior(AssertionType.Immediate, false),
-                    $"{gridRows.Caption} is {gridRows.Rows.GetPrintableValues()}");
+                    $"{gridRows.Caption} is: {gridRows.Rows.GetPrintableValues()}");
             }
         }
 
@@ -53,7 +53,7 @@ public void CheckTableHaveRowsInExactOrder(ITableWrapper gridRows, Table table)
             Assert.ShouldBecome(() => gridRows.Rows.ToStringRows().HaveValues(table.Rows.ToStringRows(), true),
                 true,
                 new AssertionBehavior(AssertionType.Immediate, false),
-                $"{gridRows.Caption} is {gridRows.Rows.GetPrintableValues()}");
+                $"{gridRows.Caption} is: {gridRows.Rows.GetPrintableValues()}");
         }
 
         [Given("(.+?) (contains|does not contain) the following rows:")]
@@ -68,14 +68,14 @@ public void CheckTableContainsRows(ITableWrapper gridRows, string behavior,  Tab
                 Assert.ShouldBecome(() => gridRows.Rows.ToStringRows().DoesntContainValues(table.Rows.ToStringRows()),
                     true,
                     new AssertionBehavior(AssertionType.Immediate, false),
-                    $"{gridRows.Caption} is {gridRows.Rows.GetPrintableValues()}");
+                    $"{gridRows.Caption} is: {gridRows.Rows.GetPrintableValues()}");
             }
             else
             {
                 Assert.ShouldBecome(() => gridRows.Rows.ToStringRows().ContainsValues(table.Rows.ToStringRows()),
                     true,
                     new AssertionBehavior(AssertionType.Immediate, false),
-                    $"{gridRows.Caption} is {gridRows.Rows.GetPrintableValues()}");
+                    $"{gridRows.Caption} is: {gridRows.Rows.GetPrintableValues()}");
             }
         }
 

src/Behavioral.Automation/Bindings/TableBinding.cs

@@ -1,14 +1,21 @@
 using System.Collections.Generic;
 using System.Linq;
 using Behavioral.Automation.Elements;
+using JetBrains.Annotations;
 
 namespace Behavioral.Automation.Services
 {
     public static class PrintValuesHelper
     {
-        public static string GetPrintableValues(this IEnumerable<ITableRowWrapper> rows)
+        public static string GetPrintableValues([NotNull] this IEnumerable<ITableRowWrapper> rows)
         {
-            return rows.SelectMany(x => x.CellsText).Aggregate((x, y) => $"{x}, {y}");
+            if (rows.Any())
+            {
+                var values = rows.Aggregate("\r\n|", (current, row) => current + (row.CellsText.Aggregate((x, y) => $" {x} | {y}") + " |\r\n |"));
+                return values.Remove(values.Length - 3);
+            }
+
+            return "\r\n Rows collection was empty";
         }
     }
 }