Skip to content

Commit fd7d32c

Browse files
authored
Merge branch 'main' into int128/Add-wait-for-workflows
2 parents 28bd3f4 + 51fbe0b commit fd7d32c

File tree

6 files changed

+21
-143
lines changed

6 files changed

+21
-143
lines changed

.github/workflows/build.yaml

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,43 +23,30 @@ on:
2323
- '*'
2424

2525
jobs:
26-
build-latest:
26+
build:
2727
uses: ./.github/workflows/reusable--build.yaml
2828
permissions:
2929
contents: read
3030
packages: write
3131

32-
build-ubuntu20:
33-
uses: ./.github/workflows/reusable--build.yaml
34-
permissions:
35-
contents: read
36-
packages: write
37-
with:
38-
file: Dockerfile.ubuntu20
39-
flavor: suffix=-ubuntu20
40-
4132
e2e-test:
4233
needs:
43-
- build-latest
44-
- build-ubuntu20
34+
- build
4535
uses: ./.github/workflows/reusable--e2e-test.yaml
4636
secrets: inherit
4737
permissions:
4838
contents: read
4939
actions: write
5040
with:
51-
runner-image-uri-latest: ${{ needs.build-latest.outputs.image-uri }}
52-
runner-image-uri-ubuntu20: ${{ needs.build-ubuntu20.outputs.image-uri }}
41+
runner-image-uri: ${{ needs.build.outputs.image-uri }}
5342

5443
release:
5544
needs:
56-
- build-latest
57-
- build-ubuntu20
45+
- build
5846
uses: ./.github/workflows/reusable--release.yaml
5947
secrets: inherit
6048
permissions:
6149
contents: read
6250
pull-requests: write
6351
with:
64-
runner-image-uri-latest: ${{ needs.build-latest.outputs.image-uri }}
65-
runner-image-uri-ubuntu20: ${{ needs.build-ubuntu20.outputs.image-uri }}
52+
runner-image-uri: ${{ needs.build.outputs.image-uri }}

.github/workflows/reusable--e2e-test-jobs.yaml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,11 @@ jobs:
3737
context: e2e-test
3838
file: e2e-test/fixture.dockerfile
3939

40-
# setup-ruby does not support ubuntu-20.04
41-
- if: inputs.expected-image-os != 'ubuntu20'
42-
uses: ruby/setup-ruby@v1
40+
- uses: ruby/setup-ruby@v1
4341
with:
4442
ruby-version: 4.0.1
45-
- if: inputs.expected-image-os != 'ubuntu20'
46-
run: ruby --version
47-
- if: inputs.expected-image-os != 'ubuntu20'
48-
run: gem --version
43+
- run: ruby --version
44+
- run: gem --version
4945

5046
- uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
5147
with:

.github/workflows/reusable--e2e-test.yaml

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,10 @@ name: e2e-test
33
on:
44
workflow_call:
55
inputs:
6-
runner-image-uri-latest:
6+
runner-image-uri:
77
type: string
88
required: true
9-
description: Image URI of runner (latest)
10-
runner-image-uri-ubuntu20:
11-
type: string
12-
required: true
13-
description: Image URI of runner (ubuntu20)
9+
description: Image URI of runner
1410
runner-base-name:
1511
type: string
1612
description: Base name of runner
@@ -44,26 +40,19 @@ jobs:
4440

4541
- run: make runner-scale-set
4642
env:
47-
ARC_RUNNER_NAME: ${{ inputs.runner-base-name }}-latest
48-
ARC_RUNNER_IMAGE_URI: ${{ inputs.runner-image-uri-latest }}
49-
- run: make runner-scale-set
50-
env:
51-
ARC_RUNNER_NAME: ${{ inputs.runner-base-name }}-ubuntu20
52-
ARC_RUNNER_IMAGE_URI: ${{ inputs.runner-image-uri-ubuntu20 }}
43+
ARC_RUNNER_NAME: ${{ inputs.runner-base-name }}
44+
ARC_RUNNER_IMAGE_URI: ${{ inputs.runner-image-uri }}
5345

5446
# Register a dummy runner scale set to ensure GitHub picks the jobs.
5547
- run: sleep 60
5648
- run: make runner-scale-set
5749
env:
5850
ARC_RUNNER_NAME: ${{ inputs.runner-base-name }}-dummy
59-
ARC_RUNNER_IMAGE_URI: ${{ inputs.runner-image-uri-latest }}
51+
ARC_RUNNER_IMAGE_URI: ${{ inputs.runner-image-uri }}
6052

6153
- run: make wait-for-runner
6254
env:
63-
ARC_RUNNER_NAME: ${{ inputs.runner-base-name }}-latest
64-
- run: make wait-for-runner
65-
env:
66-
ARC_RUNNER_NAME: ${{ inputs.runner-base-name }}-ubuntu20
55+
ARC_RUNNER_NAME: ${{ inputs.runner-base-name }}
6756
- run: make runner-logs
6857
if: always()
6958
- run: make listener-logs
@@ -93,11 +82,5 @@ jobs:
9382
runner-latest:
9483
uses: ./.github/workflows/reusable--e2e-test-jobs.yaml
9584
with:
96-
runner-name: ${{ inputs.runner-base-name }}-latest
85+
runner-name: ${{ inputs.runner-base-name }}
9786
expected-image-os: ubuntu24
98-
99-
runner-ubuntu20:
100-
uses: ./.github/workflows/reusable--e2e-test-jobs.yaml
101-
with:
102-
runner-name: ${{ inputs.runner-base-name }}-ubuntu20
103-
expected-image-os: ubuntu20

.github/workflows/reusable--release.yaml

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,10 @@ name: release
33
on:
44
workflow_call:
55
inputs:
6-
runner-image-uri-latest:
6+
runner-image-uri:
77
type: string
88
required: true
9-
description: Image URI of runner (latest)
10-
runner-image-uri-ubuntu20:
11-
type: string
12-
required: true
13-
description: Image URI of runner (ubuntu20)
9+
description: Image URI of runner
1410

1511
jobs:
1612
create-release-if-not-exists:
@@ -22,19 +18,10 @@ jobs:
2218
steps:
2319
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
2420

25-
# Ensure the runner versions are the same
26-
- id: get-runner-version-latest
21+
- id: get-runner-version
2722
run: bash hack/get-runner-version.sh
2823
env:
29-
RUNNER_IMAGE_URI: ${{ inputs.runner-image-uri-latest }}
30-
- id: get-runner-version-ubuntu20
31-
run: bash hack/get-runner-version.sh
32-
env:
33-
RUNNER_IMAGE_URI: ${{ inputs.runner-image-uri-ubuntu20 }}
34-
- run: test "$RUNNER_VERSION_LATEST" = "$RUNNER_VERSION_UBUNTU20"
35-
env:
36-
RUNNER_VERSION_LATEST: ${{ steps.get-runner-version-latest.outputs.runner-version }}
37-
RUNNER_VERSION_UBUNTU20: ${{ steps.get-runner-version-ubuntu20.outputs.runner-version }}
24+
RUNNER_IMAGE_URI: ${{ inputs.runner-image-uri }}
3825

3926
# When Renovate has updated the runner version,
4027
# automatically create a new release into GitHub Releases.
@@ -46,7 +33,7 @@ jobs:
4633
- id: create-release
4734
run: bash hack/create-release-if-not-exists.sh
4835
env:
49-
RUNNER_VERSION: ${{ steps.get-runner-version-latest.outputs.runner-version }}
36+
RUNNER_VERSION: ${{ steps.get-runner-version.outputs.runner-version }}
5037
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5138
# Trigger the build workflow against the new release
5239
RELEASE_TOKEN: ${{ steps.release-token.outputs.token }}

Dockerfile.ubuntu20

Lines changed: 0 additions & 75 deletions
This file was deleted.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ We extend the official image for the following issues:
1515
- Run both runner and Dockerd in same container for the resource efficiency of Kubernetes nodes.
1616
This image starts Dockerd under docker-init.
1717
- Add some essential packages such as `git`
18-
- Support Ubuntu 20.04 runner for backward compatibility
18+
- ~Support Ubuntu 20.04 runner for backward compatibility~
1919
- ~Run a job on both amd64 and arm64 nodes.
2020
This repository provides a multi-architectures image.
2121
([community#56720](https://github.com/orgs/community/discussions/56720))~ (resolved by [actions/runner#2601](https://github.com/actions/runner/pull/2601))

0 commit comments

Comments
 (0)