Fix detection for Brave browser

Author: tresf

src/qz/installer/apps/locator/AppAlias.java

@@ -85,15 +85,15 @@ public String getName() {
          *   "Mozilla Firefox" --> "Firefox"
          *   "Microsoft Edge" --> "Edge"
          *   "Google Chrome" --> "Chrome"
-         *   "Brave Browser" --> "Brave Browser"
+         *   "Brave Browser" --> "Brave"
          */
         public String getName(boolean stripVendor) {
+            // Strip "Browser" from "Brave Browser"
+            if(stripVendor && name.endsWith("Browser")) {
+                return name.substring(0, name.length() - 7).trim();
+            }
             if(stripVendor && name.startsWith(vendor) && !name.equals(vendor)) {
-                String stripped = name.substring(vendor.length()).trim();
-                // Don't strip "Brave" from "Brave Browser", don't return an empty string
-                if(!stripped.isEmpty() && !stripped.equalsIgnoreCase("browser")) {
-                    return stripped;
-                }
+                return name.substring(vendor.length()).trim();
             }
             return name;
         }

test/qz/installer/apps/AppLocatorTests.java

@@ -93,7 +93,7 @@ public void findRunningAppsTests(AppAlias app) {
             AppInfo appInfo = runningApp.getValue();
             log.info("[{}] found running as pid {} at '{}'", app, pid, appInfo.getExePath());
         }
-        Assert.assertFalse(runningApps.isEmpty(), String.format("Unable to find a running [%s] process", app.name()));
+        Assert.assertFalse(runningApps.isEmpty(), String.format("Unable to find a running [%s] process.  Running app count must NOT be empty.", app.name()));
     }
 
     /**