Skip to content

Commit 86655aa

Browse files
committed
Enable identity insert on view's base table
1 parent a2f2290 commit 86655aa

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
#### Unreleased
2+
3+
#### Fixed
4+
5+
- [#1231](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1231) Enable identity insert on view's base table
6+
17
## v7.1.7
28

39
#### Fixed

lib/active_record/connection_adapters/sqlserver/database_statements.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ def internal_exec_query(sql, name = "SQL", binds = [], prepare: false, async: fa
4545
log(sql, name, binds, async: async) do
4646
with_raw_connection do |conn|
4747
if id_insert_table_name = query_requires_identity_insert?(sql)
48+
# If the table name is a view, we need to get the base table name for enabling identity insert.
49+
id_insert_table_name = view_table_name(id_insert_table_name) if view_exists?(id_insert_table_name)
50+
4851
with_identity_insert_enabled(id_insert_table_name, conn) do
4952
result = internal_exec_sql_query(sql, conn)
5053
end

test/cases/view_test_sqlserver.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,12 @@ class ViewTestSQLServer < ActiveRecord::TestCase
4747
assert_equal 1, klass.count
4848
end
4949
end
50+
51+
describe 'identity insert' do
52+
it "identity insert works with views" do
53+
assert_difference("SSTestCustomersView.count", 1) do
54+
SSTestCustomersView.create!(id: 5, name: "Bob")
55+
end
56+
end
57+
end
5058
end

0 commit comments

Comments
 (0)