Aligns method naming #470
Annotations
11 warnings and 10 notices
|
lint (8.3)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v3, actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
literal-named-argument:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L35
Literal argument `'Do not export-ignore the license file'` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: 'Do not export-ignore the license file')`.
|
|
literal-named-argument:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L35
Literal argument `null` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: null)`.
|
|
literal-named-argument:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L32
Literal argument `'Use the glob pattern of the given language preset'` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: 'Use the glob pattern of the given language preset')`.
|
|
literal-named-argument:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L32
Literal argument `null` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: null)`.
|
|
literal-named-argument:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L31
Literal argument `'Use this file with glob patterns to match export-ignored artifacts'` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: 'Use this file with glob patterns to match export-ignored artifacts')`.
|
|
literal-named-argument:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L31
Literal argument `null` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: null)`.
|
|
literal-named-argument:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L30
Literal argument `'Use this glob pattern to match artifacts that should be export-ignored'` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: 'Use this glob pattern to match artifacts that should be export-ignored')`.
|
|
literal-named-argument:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L30
Literal argument `null` should be passed as a named argument for clarity.
>This literal is being passed positionally.
Passing literals positionally can make code less clear, especially with booleans, numbers, or `null`.
Help: Consider using a named argument instead: `function_name(param: null)`.
|
|
no-shorthand-ternary:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L22
Use of the shorthand ternary operator.
>Ambiguous check due to `? :` loose comparison
Help: Use null coalesce operator (`??`) or ternary operator with explicit strict comparison.
|
|
cyclomatic-complexity:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L16
Trait has high complexity.
>Trait has a cyclomatic complexity of 22, which exceeds the threshold of 15.
|
|
no-else-clause:
src/Commands/CreateCommand.php#L108
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
no-else-clause:
src/Commands/CreateCommand.php#L89
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
no-else-clause:
src/Commands/CreateCommand.php#L77
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
no-else-clause:
src/Commands/UpdateCommand.php#L119
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
no-else-clause:
src/Commands/UpdateCommand.php#L109
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
no-else-clause:
src/Commands/UpdateCommand.php#L90
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
no-else-clause:
src/Commands/UpdateCommand.php#L78
Avoid `else` clauses.
>This `else` clause can often be eliminated
Code is often clearer when the main logic is not nested inside an `if` statement.
Help: Consider refactoring to use an early return (a guard clause) to simplify the control flow.
|
|
prefer-arrow-function:
src/Presets/CommonPreset.php#L44
This closure can be simplified to a more concise arrow function.
>This traditional closure...
>...can be converted to an arrow function that implicitly returns this expression.
Arrow functions provide a more concise syntax for simple closures that do nothing but return an expression.
Arrow functions automatically capture variables from the parent scope by-value, which differs from traditional closures that use an explicit `use` clause and can capture by-reference.
Help: Consider rewriting this as an arrow function to improve readability.
|
|
no-else-clause:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L137
Avoid `elseif` clauses.
>This `elseif` adds unnecessary complexity
Complex conditional chains can often be simplified by using early returns or a `match` expression.
Help: Refactor to use guard clauses (early returns) or a `match` expression for clarity.
|
|
no-else-clause:
src/Commands/Concerns/GeneratesGitattributesOptions.php#L113
Avoid `elseif` clauses.
>This `elseif` adds unnecessary complexity
Complex conditional chains can often be simplified by using early returns or a `match` expression.
Help: Refactor to use guard clauses (early returns) or a `match` expression for clarity.
|