diff --git a/rcsb/utils/io/FileUtil.py b/rcsb/utils/io/FileUtil.py index 954c6d5..d156b33 100644 --- a/rcsb/utils/io/FileUtil.py +++ b/rcsb/utils/io/FileUtil.py @@ -366,7 +366,26 @@ def unbundleTarfile(self, tarFilePath, dirPath="."): try: with tarfile.open(tarFilePath) as tar: - tar.extractall(path=dirPath) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=dirPath) except Exception as e: logger.exception("Failing with %s", str(e)) ret = False