Skip to content

Commit 390538e

Browse files
authored
chore(docs): replace @remark with @remarks per TSDoc spec (#77)
- TSDoc specifies the tag name as `@remarks` (not `@remark`). - This aligns our comments with the spec and improves tooling support. - No runtime behavior changes. - Ref: https://tsdoc.org/pages/tags/remarks/
1 parent 3c9bf20 commit 390538e

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

.changeset/funny-baths-carry.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
"react-native-youtube-bridge": patch
3+
"@react-native-youtube-bridge/core": patch
4+
---
5+
6+
chore(docs): replace @remark with @remarks per TSDoc spec
7+
8+
- TSDoc specifies the tag name as `@remarks` (not `@remark`).
9+
- This aligns our comments with the spec and improves tooling support.
10+
- No runtime behavior changes.
11+
- Ref: https://tsdoc.org/pages/tags/remarks/

packages/core/src/types/index.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,14 +119,14 @@ export type PlayerEvents = {
119119
export type YoutubePlayerVars = {
120120
/**
121121
* This parameter specifies whether the initial video will automatically start to play when the player loads.
122-
* @remark
122+
* @remarks
123123
* - If the `muted` is not set to true when activating the `autoplay`,
124124
* - it may not work properly depending on browser policy. (https://developer.chrome.com/blog/autoplay)
125125
*/
126126
autoplay?: boolean;
127127
/**
128128
* This parameter indicates whether the video player controls are displayed.
129-
* @remark
129+
* @remarks
130130
* - `controls: false` - Player controls do not display in the player.
131131
* - `controls: true` (default) - Player controls display in the player.
132132
* @defaultValue true
@@ -152,22 +152,22 @@ export type YoutubePlayerVars = {
152152
/**
153153
* This parameter controls whether videos play inline or fullscreen on iOS.
154154
*
155-
* @remark
155+
* @remarks
156156
* Valid values are:
157157
* - `playsinline: false` - Results in fullscreen playback. This is currently the default value, though the default is subject to change.
158158
* - `playsinline: true` - Results in inline playback for mobile browsers and for WebViews created with the `allowsInlineMediaPlayback` property set to `YES`.
159159
*/
160160
playsinline?: boolean;
161161
/**
162162
* Prior to the change, this parameter indicates whether the player should show related videos when playback of the initial video ends.
163-
* @remark
163+
* @remarks
164164
* After the change, you will not be able to disable related videos. Instead, if the `rel` parameter is set to `false, related videos will come from the same channel as the video that was just played.
165165
*/
166166
rel?: boolean;
167167
/**
168168
* This parameter provides an extra security measure for the IFrame API and is only supported for IFrame embeds.
169169
*
170-
* @remark
170+
* @remarks
171171
* - When `useInlineHtml` is `true` (iOS/Android inline WebView), if not provided, the library defaults this to `https://localhost` and sets the WebView `baseUrl` accordingly so that the document origin and this value match.
172172
* - When `useInlineHtml` is `false` (remote WebView), if not provided, the external page URL defaults to `https://react-native-youtube-bridge.pages.dev` and this value follows that URL. If you pass a custom `webViewUrl` (base URL), `origin` should follow that same origin.
173173
* - In all cases, this value MUST exactly match the document's origin that hosts the iframe for the YouTube IFrame API to function correctly.

packages/react-native-youtube-bridge/src/types/youtube.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export type YoutubeViewProps = {
4343
iframeStyle?: CSSProperties;
4444
/**
4545
* If set to true, the player will use inline HTML.
46-
* @remark
46+
* @remarks
4747
* When false, the player will use a webview with the default URI (https://react-native-youtube-bridge.pages.dev).
4848
* To use a custom webview, set `webViewUrl` to your own URL.
4949
* @defaultValue true
@@ -52,7 +52,7 @@ export type YoutubeViewProps = {
5252
useInlineHtml?: boolean;
5353
/**
5454
* The URL for the WebView source.
55-
* @remark
55+
* @remarks
5656
* When `useInlineHtml` is `true`, this value is set as the `baseUrl` for HTML content.
5757
* In this case, the origin of `webViewUrl` MUST exactly match the YouTube IFrame API `origin`.
5858
* - Include the port when applicable (e.g. baseUrl `https://localhost:8081/` ⇄ origin `https://localhost:8081`).

0 commit comments

Comments
 (0)