Skip to content

Commit 306b6cb

Browse files
robhoganfacebook-github-bot
authored andcommitted
Consistently name argument, unbreak Android OSS build
Summary: 57eb56f broke Android OSS due to a variable rename that I missed in a rebase. Eg: https://github.com/facebook/react-native/actions/runs/26894263379/job/79328683517 ``` e: warnings found and -Werror specified w: file:///__w/react-native/react-native/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt:203:15 The corresponding parameter in the supertype 'CallCountTrackingChunkCallback' is named 'isLastChunk'. This may cause problems when calling this function with named arguments. > Task :packages:react-native:ReactAndroid:compileDebugOptimizedUnitTestKotlin > Task :packages:react-native:ReactAndroid:compileDebugOptimizedUnitTestKotlin FAILED > Task :react-native_popup-menu-android:extractReleaseAnnotations e: warnings found and -Werror specified ``` Changelog: Internal Differential Revision: D107397221
1 parent b766986 commit 306b6cb

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,9 @@ class MultipartStreamReaderTest {
200200
override fun onChunkComplete(
201201
headers: Map<String, String>,
202202
body: BufferedSource,
203-
done: Boolean,
203+
isLastChunk: Boolean,
204204
) {
205-
super.onChunkComplete(headers, body, done)
205+
super.onChunkComplete(headers, body, isLastChunk)
206206

207207
// Lookup using canonical case should still work.
208208
assertThat(headers["Content-Type"]).isEqualTo("application/json")

0 commit comments

Comments
 (0)