Skip to content

Commit 97b3430

Browse files
committed
fix: remove text layout internal overloads
1 parent d905a71 commit 97b3430

2 files changed

Lines changed: 2 additions & 79 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.kt

Lines changed: 0 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,6 @@ internal object TextLayoutManager {
128128
}
129129
}
130130

131-
fun setCachedSpannableForTag(reactTag: Int, sp: Spannable): Unit =
132-
setCachedSpannableForTag(reactTag, 0, sp)
133-
134131
fun setCachedSpannableForTag(
135132
reactTag: Int,
136133
fontWeightAdjustment: Int,
@@ -1073,32 +1070,6 @@ internal object TextLayoutManager {
10731070
)
10741071
}
10751072

1076-
@JvmStatic
1077-
@OptIn(UnstableReactNativeAPI::class)
1078-
fun createPreparedLayout(
1079-
assets: AssetManager,
1080-
attributedString: ReadableMapBuffer,
1081-
paragraphAttributes: ReadableMapBuffer,
1082-
width: Float,
1083-
widthYogaMeasureMode: YogaMeasureMode,
1084-
height: Float,
1085-
heightYogaMeasureMode: YogaMeasureMode,
1086-
reactTextViewManagerCallback: ReactTextViewManagerCallback?,
1087-
textEffectRegistry: TextEffectRegistry? = null,
1088-
): PreparedLayout =
1089-
createPreparedLayout(
1090-
assets,
1091-
0,
1092-
attributedString,
1093-
paragraphAttributes,
1094-
width,
1095-
widthYogaMeasureMode,
1096-
height,
1097-
heightYogaMeasureMode,
1098-
reactTextViewManagerCallback,
1099-
textEffectRegistry,
1100-
)
1101-
11021073
@JvmStatic
11031074
@OptIn(UnstableReactNativeAPI::class)
11041075
fun createPreparedLayout(
@@ -1267,34 +1238,6 @@ internal object TextLayoutManager {
12671238
}
12681239
}
12691240

1270-
@JvmStatic
1271-
@OptIn(UnstableReactNativeAPI::class)
1272-
fun measureText(
1273-
assets: AssetManager,
1274-
attributedString: MapBuffer,
1275-
paragraphAttributes: MapBuffer,
1276-
width: Float,
1277-
widthYogaMeasureMode: YogaMeasureMode,
1278-
height: Float,
1279-
heightYogaMeasureMode: YogaMeasureMode,
1280-
reactTextViewManagerCallback: ReactTextViewManagerCallback?,
1281-
attachmentsPositions: FloatArray?,
1282-
textEffectRegistry: TextEffectRegistry? = null,
1283-
): Long =
1284-
measureText(
1285-
assets,
1286-
0,
1287-
attributedString,
1288-
paragraphAttributes,
1289-
width,
1290-
widthYogaMeasureMode,
1291-
height,
1292-
heightYogaMeasureMode,
1293-
reactTextViewManagerCallback,
1294-
attachmentsPositions,
1295-
textEffectRegistry,
1296-
)
1297-
12981241
@JvmStatic
12991242
@OptIn(UnstableReactNativeAPI::class)
13001243
fun measureText(
@@ -1570,28 +1513,6 @@ internal object TextLayoutManager {
15701513
return lastAttachmentFoundInSpan
15711514
}
15721515

1573-
@JvmStatic
1574-
@OptIn(UnstableReactNativeAPI::class)
1575-
fun measureLines(
1576-
assetManager: AssetManager,
1577-
attributedString: MapBuffer,
1578-
paragraphAttributes: MapBuffer,
1579-
width: Float,
1580-
height: Float,
1581-
reactTextViewManagerCallback: ReactTextViewManagerCallback?,
1582-
textEffectRegistry: TextEffectRegistry? = null,
1583-
): WritableArray =
1584-
measureLines(
1585-
assetManager,
1586-
0,
1587-
attributedString,
1588-
paragraphAttributes,
1589-
width,
1590-
height,
1591-
reactTextViewManagerCallback,
1592-
textEffectRegistry,
1593-
)
1594-
15951516
@JvmStatic
15961517
@OptIn(UnstableReactNativeAPI::class)
15971518
fun measureLines(

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import com.facebook.react.bridge.ReactSoftExceptionLogger.logSoftException
3636
import com.facebook.react.bridge.ReadableArray
3737
import com.facebook.react.bridge.ReadableType
3838
import com.facebook.react.common.ReactConstants
39+
import com.facebook.react.common.annotations.UnstableReactNativeAPI
3940
import com.facebook.react.common.mapbuffer.MapBuffer
4041
import com.facebook.react.module.annotations.ReactModule
4142
import com.facebook.react.uimanager.BackgroundStyleApplicator.setBorderColor
@@ -1000,6 +1001,7 @@ public open class ReactTextInputManager public constructor() :
10001001
return null
10011002
}
10021003

1004+
@OptIn(UnstableReactNativeAPI::class)
10031005
public fun getReactTextUpdate(
10041006
view: ReactEditText,
10051007
props: ReactStylesDiffMap,

0 commit comments

Comments
 (0)