Allow reverse-order lists#47160
Closed
rozele wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64575365 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 11, 2025
Summary: We have a special case for treating horizontal RTL lists differently. This change adds similar functionality for capturing the correct virtualized list cell metrics when a list items children are rendered in reverse order, e.g., with `flexDirection: 'column-reverse'`. ## Changelog [General][Fixed] Fixed FlatList to support reverse ordered items Differential Revision: D64575365
Summary: We have a special case for treating horizontal RTL lists differently. This change adds similar functionality for capturing the correct virtualized list cell metrics when a list items children are rendered in reverse order, e.g., with `flexDirection: 'column-reverse'`. ## Changelog [General][Fixed] Fixed FlatList to support reverse ordered items Differential Revision: D64575365
rozele
force-pushed
the
export-D64575365
branch
from
3be01bd to
44d5422
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64575365 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 11, 2025
Summary: We have a special case for treating horizontal RTL lists differently. This change adds similar functionality for capturing the correct virtualized list cell metrics when a list items children are rendered in reverse order, e.g., with `flexDirection: 'column-reverse'`. ## Changelog [General][Fixed] Fixed FlatList to support reverse ordered items Differential Revision: D64575365
|
Any progress or update on PR to be merged soon? |
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
removed
the
Stale
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We have a special case for treating horizontal RTL lists differently. This change adds similar functionality for capturing the correct virtualized list cell metrics when a list items children are rendered in reverse order, e.g., with
flexDirection: 'column-reverse'.Changelog
[General][Fixed] Fixed FlatList to support reverse ordered items
Differential Revision: D64575365