Validate NPM token before nightly publish#56502
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Summary: Adds an NPM token validation step to the `build_npm_package` job of the React Native nightly workflow. Mirrors the same check we recently added to `create-release.yml` and the Hermes `rn-build-hermes.yml` workflows so we fail fast (with a clear message) instead of failing partway through the publish step when the token is expired or missing. ## Changelog: [Internal] - Reviewed By: fabriziocucci Differential Revision: D101594276
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101594276. |
|
This pull request has been merged in 8043a6d. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 8043a6d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds an NPM token validation step to the
build_npm_packagejob of theReact Native nightly workflow. Mirrors the same check we recently added
to
create-release.ymland the Hermesrn-build-hermes.ymlworkflowsso we fail fast (with a clear message) instead of failing partway
through the publish step when the token is expired or missing.
Changelog:
[Internal] -
Reviewed By: fabriziocucci
Differential Revision: D101594276