Use per-session output directory for Fantom native builds (#56521)#56521
Closed
javache wants to merge 1 commit into
Closed
Use per-session output directory for Fantom native builds (#56521)#56521javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101692926. |
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D101692926
branch
from
05ef52f to
3ae3696
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 21, 2026
Summary: Fixes a race condition where multiple concurrent Jest processes sharing the same checkout could delete each others native binaries. The `globalSetup` in `build.js` previously called `fs.rmSync` on the shared `native-builds/` directory before rebuilding, which could delete binaries that another process workers were actively using (causing `ENOENT` when spawning the fantom-tester binary). Each Jest session now writes native binaries to `native-builds/<run-id>/`, matching the existing pattern used for JS build outputs (`getTestBuildOutputPath`). The buck isolation directory is shared across sessions so builds remain cached. Changelog: [Internal] Reviewed By: christophpurrer, lenaic Differential Revision: D101692926
Summary: Pull Request resolved: react#56521 Fixes a race condition where multiple concurrent Jest processes sharing the same checkout could delete each others native binaries. The `globalSetup` in `build.js` previously called `fs.rmSync` on the shared `native-builds/` directory before rebuilding, which could delete binaries that another process workers were actively using (causing `ENOENT` when spawning the fantom-tester binary). Each Jest session now writes native binaries to `native-builds/<run-id>/`, matching the existing pattern used for JS build outputs (`getTestBuildOutputPath`). The buck isolation directory is shared across sessions so builds remain cached. Changelog: [Internal] Reviewed By: christophpurrer, lenaic Differential Revision: D101692926
javache
force-pushed
the
export-D101692926
branch
from
3ae3696 to
9fff1c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes a race condition where multiple concurrent Jest processes sharing the same checkout could delete each others native binaries. The
globalSetupinbuild.jspreviously calledfs.rmSyncon the sharednative-builds/directory before rebuilding, which could delete binaries that another process workers were actively using (causingENOENTwhen spawning the fantom-tester binary).Each Jest session now writes native binaries to
native-builds/<run-id>/, matching the existing pattern used for JS build outputs (getTestBuildOutputPath). The buck isolation directory is shared across sessions so builds remain cached.Changelog: [Internal]
Reviewed By: christophpurrer, lenaic
Differential Revision: D101692926