Skip to content

Commit 5259a9f

Browse files
authored
housekeeping: Added Central Package Versioning (#53)
1 parent 89cb204 commit 5259a9f

File tree

8 files changed

+77
-24
lines changed

8 files changed

+77
-24
lines changed

src/ReactiveMarbles.Mvvm.Benchmarks/ReactiveMarbles.Mvvm.Benchmarks.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="BenchmarkDotNet" Version="0.13.1" />
12-
<PackageReference Include="ReactiveUI" Version="11.*" />
11+
<PackageReference Include="BenchmarkDotNet" />
12+
<PackageReference Include="ReactiveUI" />
1313
</ItemGroup>
1414

1515
<ItemGroup>
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
<Project>
2+
<Import Project="$([MSBuild]::GetPathOfFileAbove('directory.build.props', '$(MSBuildThisFileDirectory)../'))" />
23
</Project>
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
<Project>
2+
<Import Project="$([MSBuild]::GetPathOfFileAbove('directory.build.targets', '$(MSBuildThisFileDirectory)../'))" />
23
</Project>

src/ReactiveMarbles.Mvvm.Tests/ReactiveMarbles.Mvvm.Tests.csproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,17 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="DynamicData" Version="7.4.9" />
12-
<PackageReference Include="FluentAssertions" Version="6.3.0" />
13-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
14-
<PackageReference Include="Microsoft.Reactive.Testing" Version="5.0.0" />
15-
<PackageReference Include="ReactiveUI" Version="11.5.35" />
16-
<PackageReference Include="xunit" Version="2.4.1" />
17-
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
11+
<PackageReference Include="DynamicData" />
12+
<PackageReference Include="FluentAssertions" />
13+
<PackageReference Include="Microsoft.NET.Test.Sdk" />
14+
<PackageReference Include="Microsoft.Reactive.Testing" />
15+
<PackageReference Include="ReactiveUI" />
16+
<PackageReference Include="xunit" />
17+
<PackageReference Include="xunit.runner.visualstudio">
1818
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1919
<PrivateAssets>all</PrivateAssets>
2020
</PackageReference>
21-
<PackageReference Include="coverlet.collector" Version="3.1.0">
21+
<PackageReference Include="coverlet.collector">
2222
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2323
<PrivateAssets>all</PrivateAssets>
2424
</PackageReference>

src/ReactiveMarbles.Mvvm/ReactiveMarbles.Mvvm.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="DynamicData" Version="7.4.9" />
12-
<PackageReference Include="ReactiveMarbles.Locator" Version="1.1.4" />
13-
<PackageReference Include="System.Reactive" Version="5.0.0" />
11+
<PackageReference Include="DynamicData" />
12+
<PackageReference Include="ReactiveMarbles.Locator" />
13+
<PackageReference Include="System.Reactive" />
1414
</ItemGroup>
1515

1616
</Project>

src/directory.build.props

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
<Project>
22
<PropertyGroup>
3-
<GenerateDocumentationFile>true</GenerateDocumentationFile>
4-
<Platform>AnyCPU</Platform>
5-
<IsTestProject>$(MSBuildProjectName.Contains('Tests'))</IsTestProject>
6-
<DebugType>embedded</DebugType>
73
<Authors>ReactiveUI Association Inc</Authors>
8-
<Copyright>Copyright (c) 2021 ReactiveUI Association Inc</Copyright>
4+
<Company>ReactiveUI Association Inc</Company>
5+
<Copyright>Copyright (c) ReactiveUI Association Inc © $([System.DateTime]::Now.ToString('yyyy'))</Copyright>
96
<PackageLicenseExpression>MIT</PackageLicenseExpression>
107
<PackageProjectUrl>https://github.com/reactivemarbles/Mvvm</PackageProjectUrl>
118
<PackageDescription>Common base classes for the MVVM pattern for Reactive Marbles.</PackageDescription>
@@ -15,6 +12,13 @@
1512
<PackageReleaseNotes>https://github.com/reactivemarbles/Mvvm/releases</PackageReleaseNotes>
1613
<RepositoryUrl>https://github.com/reactivemarbles/Mvvm</RepositoryUrl>
1714
<RepositoryType>git</RepositoryType>
15+
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
16+
<Nullable>enable</Nullable>
17+
<EnableNETAnalyzers>true</EnableNETAnalyzers>
18+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
19+
<Platform>AnyCPU</Platform>
20+
<IsTestProject>$(MSBuildProjectName.Contains('Tests'))</IsTestProject>
21+
<DebugType>embedded</DebugType>
1822

1923
<!-- Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
2024
<PublishRepositoryUrl>true</PublishRepositoryUrl>
@@ -25,7 +29,7 @@
2529
</PropertyGroup>
2630

2731
<ItemGroup Condition="'$(IsTestProject)' != 'true'">
28-
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
32+
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
2933
</ItemGroup>
3034

3135
<PropertyGroup>
@@ -38,22 +42,23 @@
3842
</ItemGroup>
3943

4044
<ItemGroup>
41-
<PackageReference Include="Nerdbank.GitVersioning" Version="3.4.231">
45+
<PackageReference Include="Nerdbank.GitVersioning">
4246
<PrivateAssets>all</PrivateAssets>
4347
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
4448
</PackageReference>
4549
</ItemGroup>
4650

4751
<ItemGroup>
48-
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.354">
52+
<PackageReference Include="Microsoft.SourceLink.GitHub" IncludeAssets="analyzers;build;buildMultitargeting;buildTransitive" PrivateAssets="All" />
53+
<PackageReference Include="StyleCop.Analyzers">
4954
<PrivateAssets>all</PrivateAssets>
5055
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
5156
</PackageReference>
52-
<PackageReference Include="Roslynator.Analyzers" Version="3.2.2">
57+
<PackageReference Include="Roslynator.Analyzers">
5358
<PrivateAssets>all</PrivateAssets>
5459
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
5560
</PackageReference>
56-
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="5.0.3" PrivateAssets="all" />
61+
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" PrivateAssets="all" />
5762
</ItemGroup>
5863
<ItemGroup>
5964
<AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json" Link="stylecop.json" />

src/directory.build.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
<PropertyGroup Condition="$(TargetFramework.StartsWith('tizen'))">
3939
<DefineConstants>$(DefineConstants);TIZEN</DefineConstants>
4040
</PropertyGroup>
41-
4241
<Target Name="ValidateNugetProperties" Condition="!$(IsTestProject) or $(IsTestProject) == ''" BeforeTargets="Compile">
4342
<Error Condition="$(PackageDescription) == '' or $(PackageDescription) == $(DefaultPackageDescription)" Text="The Nuget PackageDescription property needs to be set for the project. Currently : '$(PackageDescription)'" />
4443
</Target>

src/directory.packages.props

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
<?xml version="1.0" encoding="utf-8" ?>
2+
<Project>
3+
<ItemGroup>
4+
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
5+
</ItemGroup>
6+
7+
<ItemGroup>
8+
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.4.231" />
9+
</ItemGroup>
10+
11+
<ItemGroup>
12+
<PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.354" />
13+
<PackageVersion Include="Roslynator.Analyzers" Version="3.2.2" />
14+
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="5.0.3" />
15+
</ItemGroup>
16+
17+
<ItemGroup>
18+
<PackageVersion Include="BenchmarkDotNet" Version="0.13.1" />
19+
<PackageVersion Include="ReactiveUI" Version="11.5.35" />
20+
</ItemGroup>
21+
22+
<ItemGroup>
23+
<PackageVersion Include="DynamicData" Version="7.4.9" />
24+
<PackageVersion Include="ReactiveMarbles.Locator" Version="1.1.4" />
25+
<PackageVersion Include="System.Reactive" Version="5.0.0" />
26+
</ItemGroup>
27+
28+
<ItemGroup>
29+
<PackageVersion Include="coverlet.collector" Version="3.1.2" />
30+
<PackageVersion Include="coverlet.msbuild" Version="3.1.2" />
31+
<PackageVersion Include="FluentAssertions" Version="6.5.1" />
32+
<PackageVersion Include="FluentAssertions.Analyzers" Version="0.16.0" />
33+
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
34+
<PackageVersion Include="Microsoft.Reactive.Testing" Version="5.0.0" />
35+
</ItemGroup>
36+
37+
<ItemGroup>
38+
<PackageVersion Include="xunit" Version="2.4.1" />
39+
<PackageVersion Include="xunit.analyzers" Version="0.10.0" />
40+
<PackageVersion Include="xunit.runner.visualstudio" Version="2.4.3" />
41+
<PackageVersion Include="coverlet.collector" Version="3.1.0" />
42+
</ItemGroup>
43+
<Import
44+
Project="$(MSBuildThisFileDirectory)/directory.packages.support.props"
45+
Condition="Exists('$(MSBuildThisFileDirectory)/directory.packages.support.props')"
46+
/>
47+
</Project>

0 commit comments

Comments
 (0)