fix: RxRecord does not function like RxObject (#62)

added failing RxRecordTests
changed RxRecord to function like RxObject
change Notifications to internal
move DistinctEvents internal

Author: RLittlesII

src/ReactiveMarbles.Mvvm.Tests/TestFixture.cs renamed to src/ReactiveMarbles.Mvvm.Tests/RxObjectTestFixture.cs

@@ -14,7 +14,7 @@ namespace ReactiveMarbles.Mvvm.Tests;
 /// </summary>
 /// <seealso cref="RxObject" />
 [DataContract]
-public class TestFixture : RxObject
+public class RxObjectTestFixture : RxObject
 {
     [IgnoreDataMember]
     private string? _isNotNullString;
@@ -37,9 +37,9 @@ public class TestFixture : RxObject
     private string? _usesExprRaiseSet;
 
     /// <summary>
-    /// Initializes a new instance of the <see cref="TestFixture"/> class.
+    /// Initializes a new instance of the <see cref="RxObjectTestFixture"/> class.
     /// </summary>
-    public TestFixture() => TestCollection = new ObservableCollectionExtended<int>();
+    public RxObjectTestFixture() => TestCollection = new ObservableCollectionExtended<int>();
 
     /// <summary>
     /// Gets or sets the is not null string.
@@ -115,4 +115,4 @@ public string? UsesExprRaiseSet
         get => _usesExprRaiseSet;
         set => RaiseAndSetIfChanged(ref _usesExprRaiseSet, value);
     }
-}
+}

src/ReactiveMarbles.Mvvm.Tests/RxObjectTests.cs

@@ -19,7 +19,7 @@
 namespace ReactiveMarbles.Mvvm.Tests;
 
 /// <summary>
-/// Tests for the <see cref="ReactiveObject"/>.
+/// Tests for the <see cref="RxObject"/>.
 /// </summary>
 public class RxObjectTests
 {
@@ -43,7 +43,7 @@ public void ChangingShouldAlwaysArriveBeforeChanged()
         var beforeSet = "Foo";
         var afterSet = "Bar";
 
-        var fixture = new TestFixture { IsOnlyOneWord = beforeSet };
+        var fixture = new RxObjectTestFixture { IsOnlyOneWord = beforeSet };
 
         var beforeFired = false;
         fixture.Changing.Subscribe(
@@ -79,7 +79,7 @@ public void ChangingShouldAlwaysArriveBeforeChanged()
     [Fact]
     public void DeferredNotificationsDontShowUpUntilUndeferred()
     {
-        var fixture = new TestFixture();
+        var fixture = new RxObjectTestFixture();
         fixture.Changing.ToObservableChangeSet(ImmediateScheduler.Instance).Bind(out var changing).Subscribe();
         fixture.Changed.ToObservableChangeSet(ImmediateScheduler.Instance).Bind(out var changed).Subscribe();
         var propertyChangingEvents = new List<PropertyChangingEventArgs>();
@@ -135,7 +135,7 @@ public void DeferredNotificationsDontShowUpUntilUndeferred()
     [Fact]
     public void ExceptionsThrownInSubscribersShouldMarshalToThrownExceptions()
     {
-        var fixture = new TestFixture { IsOnlyOneWord = "Foo" };
+        var fixture = new RxObjectTestFixture { IsOnlyOneWord = "Foo" };
 
         fixture.Changed.Subscribe(_ => throw new Exception("Terminate!"));
         fixture.ThrownExceptions.ToObservableChangeSet(ImmediateScheduler.Instance).Bind(out var exceptionList)
@@ -152,8 +152,8 @@ public void ExceptionsThrownInSubscribersShouldMarshalToThrownExceptions()
     [Fact]
     public void ObservableForPropertyUsingExpression()
     {
-        var fixture = new TestFixture { IsNotNullString = "Foo", IsOnlyOneWord = "Baz" };
-        var output = new List<IObservedChange<TestFixture, string?>>();
+        var fixture = new RxObjectTestFixture { IsNotNullString = "Foo", IsOnlyOneWord = "Baz" };
+        var output = new List<IObservedChange<RxObjectTestFixture, string?>>();
         fixture.ObservableForProperty(x => x.IsNotNullString)
             .Subscribe(x => output.Add(x));
 
@@ -178,7 +178,7 @@ public void ObservableForPropertyUsingExpression()
     [Fact]
     public void RaiseAndSetUsingExpression()
     {
-        var fixture = new TestFixture { IsNotNullString = "Foo", IsOnlyOneWord = "Baz" };
+        var fixture = new RxObjectTestFixture { IsNotNullString = "Foo", IsOnlyOneWord = "Baz" };
         var output = new List<string>();
         fixture.Changed
             .Select(x => x.PropertyName)
@@ -193,10 +193,10 @@ public void RaiseAndSetUsingExpression()
     }
 
     /// <summary>
-    /// Test that ReactiveObject shouldn't serialize anything extra.
+    /// Test that RxObject shouldn't serialize anything extra.
     /// </summary>
     [Fact(Skip = "JSONHelper")]
-    public void ReactiveObjectShouldntSerializeAnythingExtra()
+    public void RxObjectShouldntSerializeAnythingExtra()
     {
         // var fixture = new TestFixture
         // {
@@ -225,7 +225,7 @@ public void RxObjectSmokeTest()
     {
         var outputChanging = new List<string>();
         var output = new List<string>();
-        var fixture = new TestFixture();
+        var fixture = new RxObjectTestFixture();
 
         fixture.Changing
             .Select(x => x.PropertyName)
@@ -249,12 +249,12 @@ public void RxObjectSmokeTest()
     }
 
     /// <summary>
-    /// Tests to make sure that ReactiveObject doesn't rethrow exceptions.
+    /// Tests to make sure that RxObject doesn't rethrow exceptions.
     /// </summary>
     [Fact]
-    public void ReactiveObjectShouldRethrowException()
+    public void RxObjectShouldRethrowException()
     {
-        var fixture = new TestFixture();
+        var fixture = new RxObjectTestFixture();
         var observable = fixture.WhenAnyValue(x => x.IsOnlyOneWord).Skip(1);
         observable.Subscribe(_ => throw new Exception("This is a test."));
 
@@ -268,11 +268,73 @@ public void ReactiveObjectShouldRethrowException()
             .Be("This is a test.");
     }
 
+    /// <summary>
+    /// Tests that change notifications are not delayed.
+    /// </summary>
+    [Fact]
+    public void ChangeNotificationsAreNotDelayed() =>
+
+        // Given, When, Then
+        new RxObjectTestFixture()
+            .AreChangeNotificationsDelayed()
+            .Should()
+            .BeFalse();
+
+    /// <summary>
+    /// Tests that change notifications are delayed.
+    /// </summary>
+    [Fact]
+    public void ChangeNotificationsAreDelayed()
+    {
+        // Given
+        var fixture = new RxObjectTestFixture();
+
+        // When
+        using var disposable = fixture.DelayChangeNotifications();
+
+        // Then
+        fixture
+            .AreChangeNotificationsDelayed()
+            .Should()
+            .BeTrue();
+    }
+
+    /// <summary>
+    /// Tests that change notifications are enabled.
+    /// </summary>
+    [Fact]
+    public void ChangeNotificationsAreEnabled() =>
+
+        // Given, When, Then
+        new RxObjectTestFixture()
+            .AreChangeNotificationsEnabled()
+            .Should()
+            .BeTrue();
+
+    /// <summary>
+    /// Tests that change notifications are suppressed.
+    /// </summary>
+    [Fact]
+    public void ChangeNotificationsAreSuppressed()
+    {
+        // Given
+        var fixture = new RxObjectTestFixture();
+
+        // When
+        using var disposable = fixture.SuppressChangeNotifications();
+
+        // Then
+        fixture
+            .AreChangeNotificationsEnabled()
+            .Should()
+            .BeFalse();
+    }
+
     private static void AssertCount(int expected, params ICollection[] collections)
     {
         foreach (var collection in collections)
         {
             Assert.Equal(expected, collection.Count);
         }
     }
-}
+}

src/ReactiveMarbles.Mvvm.Tests/RxRecordTestFixture.cs

@@ -0,0 +1,118 @@
+// Copyright (c) 2019-2021 ReactiveUI Association Incorporated. All rights reserved.
+// ReactiveUI Association Incorporated licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for full license information.
+
+using System.Collections.Generic;
+using System.Linq;
+using System.Runtime.Serialization;
+using DynamicData.Binding;
+
+namespace ReactiveMarbles.Mvvm.Tests;
+
+/// <summary>
+/// A test fixture.
+/// </summary>
+/// <seealso cref="RxRecord" />
+[DataContract]
+public record RxRecordTestFixture : RxRecord
+{
+    [IgnoreDataMember]
+    private string? _isNotNullString;
+
+    [IgnoreDataMember]
+    private string? _isOnlyOneWord;
+
+    private string? _notSerialized;
+
+    [IgnoreDataMember]
+    private int? _nullableInt;
+
+    [IgnoreDataMember]
+    private string? _pocoProperty;
+
+    [IgnoreDataMember]
+    private List<string>? _stackOverflowTrigger;
+
+    [IgnoreDataMember]
+    private string? _usesExprRaiseSet;
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="RxRecordTestFixture"/> class.
+    /// </summary>
+    public RxRecordTestFixture() => TestCollection = new ObservableCollectionExtended<int>();
+
+    /// <summary>
+    /// Gets or sets the is not null string.
+    /// </summary>
+    [DataMember]
+    public string? IsNotNullString
+    {
+        get => _isNotNullString;
+        set => RaiseAndSetIfChanged(ref _isNotNullString, value);
+    }
+
+    /// <summary>
+    /// Gets or sets the is only one word.
+    /// </summary>
+    [DataMember]
+    public string? IsOnlyOneWord
+    {
+        get => _isOnlyOneWord;
+        set => RaiseAndSetIfChanged(ref _isOnlyOneWord, value);
+    }
+
+    /// <summary>
+    /// Gets or sets the not serialized.
+    /// </summary>
+    public string? NotSerialized
+    {
+        get => _notSerialized;
+        set => RaiseAndSetIfChanged(ref _notSerialized, value);
+    }
+
+    /// <summary>
+    /// Gets or sets the nullable int.
+    /// </summary>
+    [DataMember]
+    public int? NullableInt
+    {
+        get => _nullableInt;
+        set => RaiseAndSetIfChanged(ref _nullableInt, value);
+    }
+
+    /// <summary>
+    /// Gets or sets the poco property.
+    /// </summary>
+    [DataMember]
+    public string? PocoProperty
+    {
+        get => _pocoProperty;
+        set => _pocoProperty = value;
+    }
+
+    /// <summary>
+    /// Gets or sets the stack overflow trigger.
+    /// </summary>
+    [DataMember]
+    public List<string>? StackOverflowTrigger
+    {
+        get => _stackOverflowTrigger;
+        set => RaiseAndSetIfChanged(ref _stackOverflowTrigger, value?.ToList());
+    }
+
+    /// <summary>
+    /// Gets or sets the test collection.
+    /// </summary>
+    [DataMember]
+    public ObservableCollectionExtended<int> TestCollection { get; protected set; }
+
+    /// <summary>
+    /// Gets or sets the uses expr raise set.
+    /// </summary>
+    [DataMember]
+    public string? UsesExprRaiseSet
+    {
+        get => _usesExprRaiseSet;
+        set => RaiseAndSetIfChanged(ref _usesExprRaiseSet, value);
+    }
+}