fix superfluousOrMissingParameterDocumentation regression

jpsim · jpsim · commit 4c770d52c991 · 2015-12-23T23:45:03.000-05:00
where commentParameters.count &gt; labelsAndParams.count
diff --git a/Source/SwiftLintFramework/Rules/ValidDocsRule.swift b/Source/SwiftLintFramework/Rules/ValidDocsRule.swift
@@ -99,7 +99,8 @@ func superfluousOrMissingParameterDocumentation(declaration: String, substructur
     let commentParameters = commentParameterMatches.map { match in
         return (comment as NSString).substringWithRange(match.rangeAtIndex(1))
     }
-    if labelsAndParams.count - commentParameters.count > optionallyDocumentedParameterCount {
+    if commentParameters.count > labelsAndParams.count ||
+        labelsAndParams.count - commentParameters.count > optionallyDocumentedParameterCount {
         return true
     }
     return !zip(commentParameters, labelsAndParams).filter {

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,8 @@ func superfluousOrMissingParameterDocumentation(declaration: String, substructur`
`99`	`99`	`let commentParameters = commentParameterMatches.map { match in`
`100`	`100`	`return (comment as NSString).substringWithRange(match.rangeAtIndex(1))`
`101`	`101`	`}`
`102`		`- if labelsAndParams.count - commentParameters.count > optionallyDocumentedParameterCount {`
	`102`	`+ if commentParameters.count > labelsAndParams.count \|\|`
	`103`	`+ labelsAndParams.count - commentParameters.count > optionallyDocumentedParameterCount {`
`103`	`104`	`return true`
`104`	`105`	`}`
`105`	`106`	`return !zip(commentParameters, labelsAndParams).filter {`