[PHPunit 9] Include AssertRegExpRector in phpunit 90 set

Author: samsonasik

config/sets/phpunit-code-quality.php

@@ -37,7 +37,6 @@
 use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertInstanceOfComparisonRector;
 use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertIssetToSpecificMethodRector;
 use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertNotOperatorRector;
-use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertRegExpRector;
 use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertSameBoolNullToSpecificMethodRector;
 use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertSameTrueFalseToAssertTrueFalseRector;
 use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertTrueFalseToSpecificMethodRector;
@@ -103,7 +102,6 @@
         AssertFalseStrposToContainsRector::class,
         AssertIssetToSpecificMethodRector::class,
         AssertInstanceOfComparisonRector::class,
-        AssertRegExpRector::class,
         AssertFuncCallToPHPUnitAssertRector::class,
         SimplifyForeachInstanceOfRector::class,
         UseSpecificWillMethodRector::class,

config/sets/phpunit90.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertRegExpRector;
 use Rector\PHPUnit\PHPUnit100\Rector\StmtsAwareInterface\WithConsecutiveRector;
 use Rector\PHPUnit\PHPUnit90\Rector\Class_\TestListenerToHooksRector;
 use Rector\PHPUnit\PHPUnit90\Rector\MethodCall\ExplicitPhpErrorApiRector;
@@ -16,6 +17,7 @@
         ExplicitPhpErrorApiRector::class,
         SpecificAssertContainsWithoutIdentityRector::class,
         WithConsecutiveRector::class,
+        AssertRegExpRector::class,
     ]);
 
     $rectorConfig->ruleWithConfiguration(RenameMethodRector::class, [

rules-tests/CodeQuality/Rector/MethodCall/AssertRegExpRector/Fixture/fixture.php.inc

@@ -23,10 +23,10 @@ final class MyTest extends \PHPUnit\Framework\TestCase
 {
     public function test()
     {
-        $this->assertRegExp('/^Message for ".*"\.$/', $string, $message);
-        $this->assertNotRegExp('/^Message for ".*"\.$/', $string, $message);
-        $this->assertNotRegExp('/^Message for ".*"\.$/', $string, $message);
-        $this->assertRegExp('/^Message for ".*"\.$/', $string, $message);
+        $this->assertMatchesRegularExpression('/^Message for ".*"\.$/', $string, $message);
+        $this->assertDoesNotMatchRegularExpression('/^Message for ".*"\.$/', $string, $message);
+        $this->assertDoesNotMatchRegularExpression('/^Message for ".*"\.$/', $string, $message);
+        $this->assertMatchesRegularExpression('/^Message for ".*"\.$/', $string, $message);
     }
 }
 

rules/CodeQuality/Rector/MethodCall/AssertRegExpRector.php

@@ -50,11 +50,11 @@ public function getRuleDefinition(): RuleDefinition
             [
                 new CodeSample(
                     '$this->assertSame(1, preg_match("/^Message for ".*"\.$/", $string), $message);',
-                    '$this->assertRegExp("/^Message for ".*"\.$/", $string, $message);'
+                    '$this->assertMatchesRegularExpression("/^Message for ".*"\.$/", $string, $message);'
                 ),
                 new CodeSample(
                     '$this->assertEquals(false, preg_match("/^Message for ".*"\.$/", $string), $message);',
-                    '$this->assertNotRegExp("/^Message for ".*"\.$/", $string, $message);'
+                    '$this->assertDoesNotMatchRegularExpression("/^Message for ".*"\.$/", $string, $message);'
                 ),
             ]
         );
@@ -163,13 +163,13 @@ private function renameMethod(MethodCall|StaticCall $node, string $oldMethodName
         if (in_array($oldMethodName, [self::ASSERT_SAME, self::ASSERT_EQUALS], true) && $oldCondition === 1
             || in_array($oldMethodName, [self::ASSERT_NOT_SAME, self::ASSERT_NOT_EQUALS], true) && $oldCondition === 0
         ) {
-            $node->name = new Identifier('assertRegExp');
+            $node->name = new Identifier('assertMatchesRegularExpression');
         }
 
         if (in_array($oldMethodName, [self::ASSERT_SAME, self::ASSERT_EQUALS], true) && $oldCondition === 0
             || in_array($oldMethodName, [self::ASSERT_NOT_SAME, self::ASSERT_NOT_EQUALS], true) && $oldCondition === 1
         ) {
-            $node->name = new Identifier('assertNotRegExp');
+            $node->name = new Identifier('assertDoesNotMatchRegularExpression');
         }
     }