[jms] Add AccessorAnnotationToAttributeRector (#799)

Author: TomasVotruba

composer.json

@@ -13,7 +13,7 @@
         "phpstan/phpstan": "^2.1.8",
         "phpstan/phpstan-webmozart-assert": "^2.0",
         "phpunit/phpunit": "^11.4",
-        "rector/rector-src": "dev-main",
+        "rector/rector-src": "dev-tv-abstract-annotation-to-attribute",
         "rector/type-perfect": "^2.0",
         "symfony/config": "^6.4",
         "symfony/dependency-injection": "^6.4",

config/sets/jms/annotations-to-attributes.php

@@ -5,7 +5,8 @@
 use Rector\Config\RectorConfig;
 use Rector\Php80\Rector\Class_\AnnotationToAttributeRector;
 use Rector\Php80\ValueObject\AnnotationToAttribute;
-use Rector\Symfony\JMS\Rector\AccessTypeAnnotationToAttributeRector;
+use Rector\Symfony\JMS\Rector\Class_\AccessTypeAnnotationToAttributeRector;
+use Rector\Symfony\JMS\Rector\Property\AccessorAnnotationToAttributeRector;
 
 /**
  * @see https://github.com/schmittjoh/serializer/pull/1320
@@ -14,7 +15,6 @@
  */
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->ruleWithConfiguration(AnnotationToAttributeRector::class, [
-        new AnnotationToAttribute('JMS\Serializer\Annotation\Accessor'),
         new AnnotationToAttribute('JMS\Serializer\Annotation\AccessorOrder'),
         new AnnotationToAttribute('JMS\Serializer\Annotation\Discriminator'),
         new AnnotationToAttribute('JMS\Serializer\Annotation\Exclude'),
@@ -46,5 +46,8 @@
         new AnnotationToAttribute('JMS\Serializer\Annotation\XmlValue'),
     ]);
 
-    $rectorConfig->rules([AccessTypeAnnotationToAttributeRector::class]);
+    $rectorConfig->rules([
+        AccessTypeAnnotationToAttributeRector::class,
+        AccessorAnnotationToAttributeRector::class,
+    ]);
 };

rules-tests/JMS/Rector/Class_/AccessTypeAnnotationToAttributeRector/config/configured_rule.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Symfony\JMS\Rector\AccessTypeAnnotationToAttributeRector;
+use Rector\Symfony\JMS\Rector\Class_\AccessTypeAnnotationToAttributeRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rule(AccessTypeAnnotationToAttributeRector::class);

rules-tests/JMS/Rector/Property/AccessorAnnotationToAttributeRector/AccessorAnnotationToAttributeRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\JMS\Rector\Property\AccessorAnnotationToAttributeRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class AccessorAnnotationToAttributeRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/JMS/Rector/Property/AccessorAnnotationToAttributeRector/Fixture/annotation_types.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Symfony\Tests\JMS\Rector\Property\AccessorAnnotationToAttributeRector\Fixture;
+
+use JMS\Serializer\Annotation as Serializer;
+
+final class AnnotationTypes
+{
+    /**
+     * @Serializer\Accessor("getSome")
+     */
+    private $value;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\JMS\Rector\Property\AccessorAnnotationToAttributeRector\Fixture;
+
+use JMS\Serializer\Annotation as Serializer;
+
+final class AnnotationTypes
+{
+    #[Serializer\Accessor(getter: 'getSome')]
+    private $value;
+}
+
+?>

rules-tests/JMS/Rector/Property/AccessorAnnotationToAttributeRector/Fixture/keep_given_key.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Symfony\Tests\JMS\Rector\Property\AccessorAnnotationToAttributeRector\Fixture;
+
+use JMS\Serializer\Annotation as Serializer;
+
+final class KeepGivenKey
+{
+    /**
+     * @Serializer\Accessor(setter="setSome")
+     */
+    private $value;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\JMS\Rector\Property\AccessorAnnotationToAttributeRector\Fixture;
+
+use JMS\Serializer\Annotation as Serializer;
+
+final class KeepGivenKey
+{
+    #[Serializer\Accessor(setter: 'setSome')]
+    private $value;
+}
+
+?>

rules-tests/JMS/Rector/Property/AccessorAnnotationToAttributeRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\JMS\Rector\Property\AccessorAnnotationToAttributeRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(AccessorAnnotationToAttributeRector::class);
+};