Skip to content

Commit 3fb5171

Browse files
Do not change method if name does not need to change (#700)
1 parent 4661c01 commit 3fb5171

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

rules/CodeQuality/Rector/ClassMethod/ActionSuffixRemoverRector.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,18 @@ public function refactor(Node $node): ?Node
7272
return null;
7373
}
7474

75-
$this->removeSuffix($node, 'Action');
76-
77-
return $node;
75+
return $this->removeSuffix($node, 'Action');
7876
}
7977

80-
private function removeSuffix(ClassMethod $classMethod, string $suffixToRemove): void
78+
private function removeSuffix(ClassMethod $classMethod, string $suffixToRemove): ?ClassMethod
8179
{
8280
$name = $this->nodeNameResolver->getName($classMethod);
8381

8482
$newName = Strings::replace($name, sprintf('#%s$#', $suffixToRemove), '');
83+
if ($newName === $name) {
84+
return null;
85+
}
8586
$classMethod->name = new Identifier($newName);
87+
return $classMethod;
8688
}
8789
}

0 commit comments

Comments
 (0)