Closes #823 Fixes rectorphp/rector#9361

Author: samsonasik

rules-tests/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector/Fixture/skip_difference_class.php.inc

@@ -10,7 +10,6 @@ final class SkipDifferentClass extends AbstractExtension
     {
         return [
             new \Twig\TwigFunction('some_function', [DifferentClass::class, 'someFunction']),
-            new \Twig\TwigFunction('some_function', $this->someFunction(...)),
         ];
     }
 

rules-tests/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector/Fixture/some_get_functions.php.inc

@@ -37,6 +37,8 @@ final class SomeGetFunctions extends AbstractExtension
 
 namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\GetFunctionsToAsTwigFunctionAttributeRector\Fixture;
 
+use Twig\Extension\AbstractExtension;
+
 final class SomeGetFunctions
 {
     #[\Twig\Attribute\AsTwigFunction('some_function')]

rules/Symfony73/GetMethodToAsTwigAttributeTransformer.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\AttributeGroup;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
+use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Name\FullyQualified;
@@ -18,7 +19,10 @@
 use PhpParser\Node\Stmt\Return_;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\ObjectType;
+use Rector\NodeNameResolver\NodeNameResolver;
+use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
+use Rector\Symfony\Enum\TwigClass;
 use Rector\Symfony\Symfony73\NodeAnalyzer\LocalArrayMethodCallableMatcher;
 use Rector\Symfony\Symfony73\NodeRemover\ReturnEmptyArrayMethodRemover;
 
@@ -31,7 +35,9 @@ public function __construct(
         private LocalArrayMethodCallableMatcher $localArrayMethodCallableMatcher,
         private ReturnEmptyArrayMethodRemover $returnEmptyArrayMethodRemover,
         private ReflectionProvider $reflectionProvider,
-        private VisibilityManipulator $visibilityManipulator
+        private VisibilityManipulator $visibilityManipulator,
+        private NodeNameResolver $nodeNameResolver,
+        private NodeTypeResolver $nodeTypeResolver
     ) {
     }
 
@@ -53,7 +59,6 @@ public function transformClassGetMethodToAttributeMarker(
         }
 
         $hasChanged = false;
-
         foreach ((array) $getMethod->stmts as $stmt) {
             // handle return array simple case
             if (! $stmt instanceof Return_) {
@@ -110,6 +115,10 @@ public function transformClassGetMethodToAttributeMarker(
             $this->returnEmptyArrayMethodRemover->removeClassMethodIfArrayEmpty($class, $returnArray, $methodName);
         }
 
+        if ($hasChanged && $class->extends instanceof FullyQualified && $class->extends->toString() == TwigClass::TWIG_EXTENSION) {
+            $class->extends = null;
+        }
+
         return $hasChanged;
     }