From 4513c9c4416b6870504c80116bb68d251363ffb7 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 13 Sep 2025 17:23:51 +0700 Subject: [PATCH] Clean up PHPStan ignore errors --- phpstan.neon | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/phpstan.neon b/phpstan.neon index a3fb1435..878dd3e3 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -42,14 +42,12 @@ parameters: - '#Calling PHPStan\\Reflection\\Php\\PhpParameterReflection\:\:getName\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version#' # false positive - - '#Access to an undefined property Rector\\Core\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#' - '#but class PhpParser\\Node\\Stmt\\Expression is not generic#' - '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#' # false positive - '#Parameters should have "PhpParser\\Node\\Expr\\Closure" types as the only types passed to this method#' - '#Parameter 1 should use "PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionMethod" type as the only type passed to this method#' - - '#Parameter \#1 \$stmtsAware of method Rector\\NodeAnalyzer\\TerminatedNodeAnalyzer\:\:isAlwaysTerminated\(\) expects Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface, PhpParser\\Node\\Stmt\\ClassMethod given#' # more advanced usage, but not always working # see https://github.com/rectorphp/rector-src/actions/runs/11798721617/job/32865546672?pr=6422#step:5:110 @@ -59,9 +57,5 @@ parameters: - identifier: argument.type - identifier: assign.propertyType - - '#::provideMinPhpVersion\(\) never returns \d+ so it can be removed from the return type#' - - # node finder - - - identifier: return.type - path: rules/Symfony73/NodeAnalyzer/CommandArgumentsAndOptionsResolver.php + # avoid notice on run on php 8.3 + - identifier: typeCoverage.constantTypeCoverage