Fixes

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Author: alinabuzachis

changelogs/fragments/fixes.yml

@@ -0,0 +1,12 @@
+breaking_changes:
+  - setup_aws_credentials - Support for the ``EC2_ACCESS_KEY`` environment variable been removed in the latest major release of amazon.aws 10.0.0 and removed from this role. Please use the ``aws_access_key`` parameter or``AWS_ACCESS_KEY_ID`` environment variable instead (https://github.com/redhat-cop/cloud.aws_ops/pull/166).
+  - setup_aws_credentials - Support for the ``EC2_REGION`` environment variable been removed in the latest major release of amazon.aws 10.0.0 and removed from this role. Please use the ``region` parameter or ``AWS_REGION`` environment variable instead (https://github.com/redhat-cop/cloud.aws_ops/pull/166).
+  - setup_aws_credentials - Support for the ``EC2_SECRET_KEY`` environment variable been removed in the latest major release of amazon.aws 10.0.0 and removed from this role. Please use the ``aws_secret_key` parameter or ``AWS_SECRET_ACCESS_KEY`` environment variable instead (https://github.com/redhat-cop/cloud.aws_ops/pull/166).
+  - setup_aws_credentials - Support for the ``EC2_SECURITY_TOKEN`` and the ``AWS_SECURITY_TOKEN`` environment variable been removed in the latest major release of amazon.aws 10.0.0 and removed from this role. Please use the ``aws_session_token` parameter or ``AWS_SESSION_TOKEN`` environment variable instead (https://github.com/redhat-cop/cloud.aws_ops/pull/166).
+  - setup_aws_credentials - Support for the ``EC2_URL_TOKEN`` environment variable been removed in the latest major release of amazon.aws 10.0.0 and removed from this role. Please use the ``aws_endpoint_url` parameter or ``AWS_URL`` environment variable instead (https://github.com/redhat-cop/cloud.aws_ops/pull/166).
+
+bugfixes:
+  - Fix integration tests to work with ansible-core 2.19 (https://github.com/redhat-cop/cloud.aws_ops/pull/166).
+
+minor_changes:
+  - documentation - Update playbooks and roles documentation to provide updated information (https://github.com/redhat-cop/cloud.aws_ops/pull/166).

playbooks/upload_file_to_s3.yaml

@@ -7,7 +7,7 @@
     group/aws:
       aws_access_key: "{{ aws_access_key | default(omit) }}"
       aws_secret_key: "{{ aws_secret_key | default(omit) }}"
-      session_token: "{{ aws_security_token | default(omit) }}"
+      session_token: "{{ aws_session_token | default(omit) }}"
       profile: "{{ aws_profile | default(omit) }}"
 
   tasks:

playbooks/webapp/vars/main.yaml

@@ -22,7 +22,7 @@ rds_allocated_storage_gb: 20
 rds_instance_class: db.m6g.large
 rds_instance_name: mysampledb123
 rds_engine: postgres
-rds_engine_version: "16.2"
+rds_engine_version: "16.3"
 bastion_host_type: t3.micro
 bastion_host_venv_path: ~/env
 rds_listening_port: 5432

roles/awsconfig_apigateway_with_lambda_integration/tasks/main.yml

@@ -9,4 +9,4 @@
         - lambda.yml
         - apigateway.yml
       loop_control:
-        label: "{{ item }}"
+        label: "{{ item }}"

roles/customized_ami/defaults/main.yml

@@ -4,7 +4,7 @@ customized_ami_source_ami_filters:
   architecture: x86_64
   virtualization-type: hvm
   root-device-type: ebs
-  name: Fedora-Cloud-Base-37-*
+  name: Fedora-Cloud-Base-39-*
 customized_ami_source_ami_user_name: fedora
 
 customized_ami_vpc_cidr: 10.1.0.0/16

roles/move_objects_between_buckets/tasks/main.yml

@@ -52,7 +52,7 @@
     - name: Fail when the source s3 bucket is not empty and move_objects_between_buckets_delete_empty_source_bucket is true
       ansible.builtin.fail:
         msg: The source must be emptied before it can be deleted.
-      when: move_objects_between_buckets_delete_empty_source_bucket | default(false) and move_objects_between_buckets_source_bucket_info.s3_keys
+      when: move_objects_between_buckets_delete_empty_source_bucket | default(false) and move_objects_between_buckets_source_bucket_info.s3_keys | length != 0
 
     - name: Delete source s3 bucket when empty
       amazon.aws.s3_bucket:

tests/integration/targets/test_deploy_flask_app/roles/run_deploy_flask_app/vars/main.yaml

@@ -19,7 +19,7 @@ rds_allocated_storage_gb: 20
 rds_instance_class: db.m6g.large
 rds_instance_name: mysampledb123
 rds_engine: postgres
-rds_engine_version: "16.2"
+rds_engine_version: "16.3"
 bastion_host_type: t3.micro
 bastion_host_venv_path: ~/env
 image_filter: Fedora-Cloud-Base-39-*

tests/integration/targets/test_manage_vpc_peering/tasks/validate.yml

@@ -14,4 +14,4 @@
     - name: Validate that VPC peering was found as expected
       ansible.builtin.assert:
         that:
-          - __vpc_peering.result | length == 1
+          - __vpc_peering.vpc_peering_connections | length == 1

tests/integration/targets/test_upload_file_to_s3/templates/upload_file_vars.yaml.j2

@@ -1,6 +1,6 @@
 ---
 aws_access_key: "{{ aws_access_key }}"
-aws_access_key: "{{ aws_secret_key }}"
+aws_secret_key: "{{ aws_secret_key }}"
 {% if security_token is defined %}
 aws_session_token: "{{ security_token }}"
 {% endif %}