Support managed_disk_type

Add support for specifying managed_disk_type.  This is a prerequisite
for supporting snapshots.

Also fixed variable names to include role prefix to prevent variable
collisions.

fixes #99

Author: p3ck

.ansible-lint

@@ -0,0 +1,4 @@
+profile: production
+
+exclude_paths:
+  - tests/integration/

changelogs/fragments/20250110-azure_virtual_machine_with_public_ip.yml

@@ -0,0 +1,6 @@
+bugfixes:
+  - Adding managed_disk_type as possible option in role azure_virtual_machine_with_public_ip
+
+trivial:
+  - Renamed register variables in azure_virtual_machine_with_public_ip to include pre-pended
+    role name to prevent variable name collisions.

roles/azure_virtual_machine_with_public_ip/README.md

@@ -45,6 +45,7 @@ Contains the following:
   - **name**: (Required) Name of the availability set.
   - **platform_fault_domain_count**: Fault domains define the group of virtual machines that share a common power source and network switch. Should be between 1 and 3.
   - **platform_update_domain_count**: Update domains indicate groups of virtual machines and underlying physical hardware that can be rebooted at the same time.
+  - **sku**: Define if the availability set supports managed disks. Choices are Classic and Aligned, Default is Classic. Aligned is needed when specifying managed_disk_type for os_disk and data_disks.
 * **azure_virtual_machine_with_public_ip_delete_resource_group**: Relevant for **delete** operation. Change to true in case Resource Group deletion should be done as part of this role deletion (default: false) 
 
 Limitations

roles/azure_virtual_machine_with_public_ip/meta/argument_specs.yml

@@ -70,6 +70,20 @@ argument_specs:
               - The image used to build the VM. For custom images, the name of the image. To narrow the search to a specific resource group, a dict with the keys name and resource_group.
               - For Marketplace images, a dict with the keys publisher, offer, sku, and version.
               - Set O(version=latest) to get the most recent version of a given image.
+          managed_disk_type:
+            type: "str"
+            description:
+              - Managed OS disk type.
+              - Create OS disk with managed disk if defined.
+              - If not defined, the OS disk will be created with virtual hard disk (VHD).
+            choices:
+              - "Standard_LRS"
+              - "StandardSSD_LRS"
+              - "StandardSSD_ZRS"
+              - "Premium_LRS"
+              - "Premium_ZRS"
+              - "UltraSSD_LRS"
+            required: false
           ssh_pw_enabled:
             description: Enable/disable SSH passwords.
             choices: ['yes', 'no']
@@ -93,8 +107,6 @@ argument_specs:
             description:
               - Initial disk size in GB for blank data disks. Cannot be larger than 1023 GB.
               - Can only be modified when VM is deallocated.
-          managed_disk_type:
-            description: Managed data disk type.
           storage_account_name:
             description: Name of an existing storage account that supports creation of VHD blobs.
           storage_blob_name:
@@ -115,3 +127,7 @@ argument_specs:
               - Should be between 1 and 3.
           platform_update_domain_count:
             description: Update domains indicate groups of virtual machines and underlying physical hardware that can be rebooted at the same time.
+          sku:
+            description: Define if the availability set supports managed disks.
+            choices: ['Classic', 'Aligned']
+            default: 'Classic'

roles/azure_virtual_machine_with_public_ip/tasks/create.yml

@@ -19,7 +19,7 @@
   ansible.builtin.fail:
     msg: Azure location must be defined as azure_virtual_machine_with_public_ip_region
   when:
-    - rg_info.resourcegroups | length == 0
+    - azure_virtual_machine_with_public_ip_rg_info.resourcegroups | length == 0
     - azure_virtual_machine_with_public_ip_region is not defined
 
 - name: Create resource group if it doesn't already exists
@@ -30,7 +30,7 @@
     azure_manage_resource_group_name: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
     azure_manage_resource_group_region: "{{ azure_virtual_machine_with_public_ip_region }}"
     azure_manage_resource_group_tags: "{{ azure_virtual_machine_with_public_ip_tags | default({}) }}"
-  when: rg_info.resourcegroups | length == 0
+  when: azure_virtual_machine_with_public_ip_rg_info.resourcegroups | length == 0
 
 # Set tags for VM
 - name: Set tags for VM
@@ -44,10 +44,10 @@
     - name: No network interface specified -> get virtual network info
       azure.azcollection.azure_rm_virtualnetwork_info:
         resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
-      register: vnet_info
+      register: azure_virtual_machine_with_public_ip_vnet_info
 
     - name: Create virtual network if not already exist
-      when: vnet_info.virtualnetworks | length == 0
+      when: azure_virtual_machine_with_public_ip_vnet_info.virtualnetworks | length == 0
       block:
         - name: Check virtual network CIDR address prefixes
           ansible.builtin.fail:
@@ -75,7 +75,7 @@
     - name: Refresh virtual network info
       azure.azcollection.azure_rm_virtualnetwork_info:
         resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
-      register: vnet_info
+      register: azure_virtual_machine_with_public_ip_vnet_info
 
     - name: Create default public ip for default nic
       azure.azcollection.azure_rm_publicipaddress:
@@ -91,8 +91,8 @@
         azure_manage_network_interface_resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
         azure_manage_network_interface_interface:
           name: "{{ vm_name }}"
-          vnet_name: "{{ vnet_info.virtualnetworks[0].name }}" # This is how the azure_rm_virtualmachine module creates its default network interface - using the first vnet
-          subnet_name: "{{ vnet_info.virtualnetworks[0].subnets[0].name }}"
+          vnet_name: "{{ azure_virtual_machine_with_public_ip_vnet_info.virtualnetworks[0].name }}" # This is how the azure_rm_virtualmachine module creates its default network interface - using the first vnet
+          subnet_name: "{{ azure_virtual_machine_with_public_ip_vnet_info.virtualnetworks[0].subnets[0].name }}"
           ip_configurations:
             - name: default
               primary: true
@@ -108,7 +108,7 @@
   azure.azcollection.azure_rm_availabilityset_info:
     resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
     name: "{{ azure_virtual_machine_with_public_ip_availability_set.name }}"
-  register: aset_info
+  register: azure_virtual_machine_with_public_ip_aset_info
   when: azure_virtual_machine_with_public_ip_availability_set is defined
 
 - name: Create availability set
@@ -117,11 +117,12 @@
     name: "{{ azure_virtual_machine_with_public_ip_availability_set.name }}"
     platform_update_domain_count: "{{ azure_virtual_machine_with_public_ip_availability_set.platform_update_domain_count | default(omit) }}"
     platform_fault_domain_count: "{{ azure_virtual_machine_with_public_ip_availability_set.platform_fault_domain_count | default(omit) }}"
+    sku: "{{ azure_virtual_machine_with_public_ip_availability_set.sku | default(omit) }}"
     tags:
       _own_availability_set_: "{{ azure_virtual_machine_with_public_ip_availability_set.name }}"
   when:
     - azure_virtual_machine_with_public_ip_availability_set is defined
-    - aset_info.ansible_info.azure_availabilitysets | length == 0
+    - azure_virtual_machine_with_public_ip_aset_info.ansible_info.azure_availabilitysets | length == 0
 
 # Create/update VM
 - name: Create/Update VM
@@ -131,6 +132,7 @@
     vm_size: "{{ azure_virtual_machine_with_public_ip_vm.size | default(omit) }}"
     network_interfaces: "{{ azure_virtual_machine_with_public_ip_vm.network_interfaces | default(vm_name) }}"
     os_type: "{{ azure_virtual_machine_with_public_ip_vm.os | default(omit) }}"
+    managed_disk_type: "{{ azure_virtual_machine_with_public_ip_vm.managed_disk_type | default(omit) }}"
     availability_set: "{{ azure_virtual_machine_with_public_ip_availability_set.name | default(omit) }}"
     image: "{{ azure_virtual_machine_with_public_ip_vm.image | default(omit) }}"
     admin_username: "{{ azure_virtual_machine_with_public_ip_vm.admin_username | default(omit) }}"

roles/azure_virtual_machine_with_public_ip/tasks/delete.yml

@@ -18,7 +18,7 @@
     name: "{{ azure_virtual_machine_with_public_ip_availability_set.name }}"
     tags:
       _own_availability_set_
-  register: _aset_info
+  register: azure_virtual_machine_with_public_ip_aset_info
   when: azure_virtual_machine_with_public_ip_availability_set is defined
 
 - name: Delete availability set if created by role
@@ -28,7 +28,7 @@
     state: absent
   when:
     - azure_virtual_machine_with_public_ip_availability_set is defined
-    - _aset_info.ansible_info.azure_availabilitysets | length == 1
+    - azure_virtual_machine_with_public_ip_aset_info.ansible_info.azure_availabilitysets | length == 1
     - azure_virtual_machine_with_public_ip_remove_on_absent in ['all', 'all_autocreated']
 
 # Delete Virtual network if created by role
@@ -38,15 +38,15 @@
     name: "{{ vm_name }}"
     tags:
       _own_vnet_
-  register: _vnet_info
+  register: azure_virtual_machine_with_public_ip_vnet_info
 
 - name: Delete Virtual network if created by role
   azure.azcollection.azure_rm_virtualnetwork:
     resource_group: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
     name: "{{ vm_name }}"
     state: absent
   when:
-    - _vnet_info.virtualnetworks | length == 1
+    - azure_virtual_machine_with_public_ip_vnet_info.virtualnetworks | length == 1
     - azure_virtual_machine_with_public_ip_remove_on_absent in ['all', 'all_autocreated']
 
 - name: Delete Resource group if requested

roles/azure_virtual_machine_with_public_ip/tasks/main.yml

@@ -6,13 +6,13 @@
 - name: Get resource group info
   azure.azcollection.azure_rm_resourcegroup_info:
     name: "{{ azure_virtual_machine_with_public_ip_resource_group }}"
-  register: rg_info
+  register: azure_virtual_machine_with_public_ip_rg_info
 
 - name: Fail when resource group doesn't exist
   ansible.builtin.fail:
     msg: Resource group {{ azure_virtual_machine_with_public_ip_resource_group }} does not exist
   when: 
-  - rg_info.resourcegroups | length == 0
+  - azure_virtual_machine_with_public_ip_rg_info.resourcegroups | length == 0
   - azure_virtual_machine_with_public_ip_operation != 'create'
 
 - name: Power Off VM