fix: address codex review for PR1 (core)

- Fix CLI step labels to match executor order
- Fix GEO coordinates to lat,lon order in integration tests
- Move JSON path to top-level field property in tests
- Use sys.exit() instead of exit() in CLI
- Use transaction=False for quantize pipeline

Author: nkanu17

redisvl/cli/migrate.py

@@ -42,13 +42,13 @@ def __init__(self):
         if not hasattr(self, command):
             print(f"Unknown subcommand: {args.command}")
             parser.print_help()
-            exit(1)
+            sys.exit(1)
 
         try:
             getattr(self, command)()
         except Exception as e:
             logger.error(e)
-            exit(1)
+            sys.exit(1)
 
     def helper(self):
         parser = argparse.ArgumentParser(
@@ -219,10 +219,10 @@ def _make_progress_callback():
         step_labels = {
             "enumerate": "[1/8] Enumerate keys",
             "bgsave": "[2/8] BGSAVE snapshot",
-            "drop": "[3/8] Drop index",
-            "quantize": "[4/8] Quantize vectors",
-            "field_rename": "[5/8] Rename fields",
-            "key_rename": "[6/8] Rename keys",
+            "field_rename": "[3/8] Rename fields",
+            "drop": "[4/8] Drop index",
+            "key_rename": "[5/8] Rename keys",
+            "quantize": "[6/8] Quantize vectors",
             "create": "[7/8] Create index",
             "index": "[8/8] Re-indexing",
             "validate": "Validate",

redisvl/migration/executor.py

@@ -1007,7 +1007,7 @@ def _quantize_vectors(
 
         for i in range(0, remaining_keys, batch_size):
             batch = keys[i : i + batch_size]
-            pipe = client.pipeline()
+            pipe = client.pipeline(transaction=False)
             undo = BatchUndoBuffer()
             keys_updated_in_batch: set[str] = set()
 

tests/integration/test_migration_comprehensive.py

@@ -93,7 +93,7 @@ def sample_docs():
             "description": "First product description",
             "category": "electronics",
             "price": 99.99,
-            "location": "-122.4194,37.7749",  # SF coordinates
+            "location": "37.7749,-122.4194",  # SF coordinates (lat,lon)
             "embedding": array_to_buffer([0.1, 0.2, 0.3, 0.4], "float32"),
         },
         {
@@ -102,7 +102,7 @@ def sample_docs():
             "description": "Second service description",
             "category": "software",
             "price": 149.99,
-            "location": "-73.9857,40.7484",  # NYC coordinates
+            "location": "40.7484,-73.9857",  # NYC coordinates (lat,lon)
             "embedding": array_to_buffer([0.2, 0.3, 0.4, 0.5], "float32"),
         },
         {
@@ -111,7 +111,7 @@ def sample_docs():
             "description": "",  # Empty for index_empty tests
             "category": "",  # Empty for index_empty tests
             "price": 0,
-            "location": "-118.2437,34.0522",  # LA coordinates
+            "location": "34.0522,-118.2437",  # LA coordinates (lat,lon)
             "embedding": array_to_buffer([0.3, 0.4, 0.5, 0.6], "float32"),
         },
     ]
@@ -1258,15 +1258,15 @@ def json_schema(self, unique_ids):
                 "storage_type": "json",
             },
             "fields": [
-                {"name": "doc_id", "type": "tag", "attrs": {"path": "$.doc_id"}},
-                {"name": "title", "type": "text", "attrs": {"path": "$.title"}},
-                {"name": "category", "type": "tag", "attrs": {"path": "$.category"}},
-                {"name": "price", "type": "numeric", "attrs": {"path": "$.price"}},
+                {"name": "doc_id", "type": "tag", "path": "$.doc_id"},
+                {"name": "title", "type": "text", "path": "$.title"},
+                {"name": "category", "type": "tag", "path": "$.category"},
+                {"name": "price", "type": "numeric", "path": "$.price"},
                 {
                     "name": "embedding",
                     "type": "vector",
+                    "path": "$.embedding",
                     "attrs": {
-                        "path": "$.embedding",
                         "algorithm": "hnsw",
                         "dims": 4,
                         "distance_metric": "cosine",
@@ -1320,7 +1320,7 @@ def test_json_add_field(
                             {
                                 "name": "status",
                                 "type": "tag",
-                                "attrs": {"path": "$.status"},
+                                "path": "$.status",
                             }
                         ],
                     },