Hide extract/copy path context menu actions where it doesn't make sense

It doesn't make sense to extract folders, so that's hidden. And same for
unknown files, there's no path to copy so we shouldn't think the user
that it could be possible.

Author: redstrate

apps/sagasu/include/filetreemodel.h

@@ -28,6 +28,12 @@ class FileTreeModel : public QAbstractItemModel
 public:
     explicit FileTreeModel(HashDatabase &database, bool showUnknown, const QString &gamePath, SqPackResource *data, QObject *parent = nullptr);
 
+    enum CustomRoles {
+        PathRole = Qt::UserRole,
+        IsUnknown,
+        IsFolder,
+    };
+
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
     int columnCount(const QModelIndex &parent = QModelIndex()) const override;
 

apps/sagasu/src/filetreemodel.cpp

@@ -104,7 +104,7 @@ QVariant FileTreeModel::data(const QModelIndex &index, int role) const
         return {};
 
     auto item = static_cast<TreeInformation *>(index.internalPointer());
-    if (role == Qt::UserRole) {
+    if (role == PathRole) {
         if (item->type != TreeType::File || item->name.isEmpty()) {
             return {};
         }
@@ -122,6 +122,10 @@ QVariant FileTreeModel::data(const QModelIndex &index, int role) const
         }
 
         return path;
+    } else if (role == IsUnknown) {
+        return item->name.isEmpty(); // unknown files/folders have no name (obviously, we don't know what its named!)
+    } else if (role == IsFolder) {
+        return item->type == TreeType::Folder;
     } else if (role == Qt::DisplayRole) {
         if (item->type == TreeType::Folder) {
             if (item->name.isEmpty()) {

apps/sagasu/src/filetreewindow.cpp

@@ -63,30 +63,38 @@ FileTreeWindow::FileTreeWindow(HashDatabase &database, const QString &gamePath,
         auto index = treeWidget->indexAt(pos);
 
         if (index.isValid()) {
-            auto path = m_searchModel->data(index, Qt::UserRole).toString();
+            const auto path = m_searchModel->data(index, FileTreeModel::CustomRoles::PathRole).toString();
+            const auto isUnknown = m_searchModel->data(index, FileTreeModel::CustomRoles::IsUnknown).toBool();
+            const auto isFolder = m_searchModel->data(index, FileTreeModel::CustomRoles::IsFolder).toBool();
 
             auto menu = new QMenu();
 
-            auto extractAction = menu->addAction(i18nc("@action:inmenu", "Extract…"));
-            extractAction->setIcon(QIcon::fromTheme(QStringLiteral("archive-extract-symbolic")));
-            connect(extractAction, &QAction::triggered, this, [this, path] {
-                Q_EMIT extractFile(path);
-            });
-
-            auto copyFilePathAction = menu->addAction(i18nc("@action:inmenu", "Copy file path"));
-            copyFilePathAction->setIcon(QIcon::fromTheme(QStringLiteral("edit-copy-symbolic")));
-            connect(copyFilePathAction, &QAction::triggered, this, [this, path] {
-                QClipboard *clipboard = QGuiApplication::clipboard();
-                clipboard->setText(path);
-            });
+            // It doesn't make sense to extract folders
+            if (!isFolder) {
+                auto extractAction = menu->addAction(i18nc("@action:inmenu", "Extract…"));
+                extractAction->setIcon(QIcon::fromTheme(QStringLiteral("archive-extract-symbolic")));
+                connect(extractAction, &QAction::triggered, this, [this, path] {
+                    Q_EMIT extractFile(path);
+                });
+            }
+
+            // It doesn't make sense to copy file paths for... a file or folder that doesn't have a path.
+            if (!isUnknown) {
+                auto copyFilePathAction = menu->addAction(i18nc("@action:inmenu", "Copy file path"));
+                copyFilePathAction->setIcon(QIcon::fromTheme(QStringLiteral("edit-copy-symbolic")));
+                connect(copyFilePathAction, &QAction::triggered, this, [this, path] {
+                    QClipboard *clipboard = QGuiApplication::clipboard();
+                    clipboard->setText(path);
+                });
+            }
 
             menu->exec(treeWidget->mapToGlobal(pos));
         }
     });
 
     connect(treeWidget, &QTreeView::clicked, [this, treeWidget](const QModelIndex &item) {
         if (item.isValid()) {
-            auto path = m_searchModel->data(item, Qt::UserRole).toString();
+            auto path = m_searchModel->data(item, FileTreeModel::CustomRoles::PathRole).toString();
             Q_EMIT pathSelected(path);
         }
     });