lint

Author: regisoc

modules/redcap/tools/redcap2linst.php

@@ -162,6 +162,16 @@ function updateREDCapDictionaryInstrumentEntries(
         'untouched' => 0
     ];
 
+    // closure for escaped html
+    $cleanHTML = fn($v) => is_string($v)
+        ? htmlspecialchars(
+            $v,
+            ENT_COMPAT | ENT_SUBSTITUTE | ENT_HTML5,
+            'UTF-8',
+            false
+        )
+        : $v;
+
     // go through entries for this instrument
     foreach ($redcap_dictionary as $redcap_dictionary_entry) {
         // get the db correspoding field name
@@ -179,14 +189,6 @@ function updateREDCapDictionaryInstrumentEntries(
 
         // escape HTML from this entry to compare
         // same method use in Database class -> update
-        $cleanHTML = fn($v) => is_string($v)
-            ? htmlspecialchars(
-                $v,
-                ENT_COMPAT | ENT_SUBSTITUTE | ENT_HTML5,
-                'UTF-8',
-                false
-            )
-            : $v;
         $escaped_props        = array_map(
             $cleanHTML,
             $redcap_dictionary_entry->toArray()