Skip to content

Commit bc8cb32

Browse files
authored
Fix log_static and mcap build (#11)
* Use log_static instead of log_timeless * Fix mcap build * Remove outdated comment regarding pypi deps in pixi
1 parent 162bbd7 commit bc8cb32

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

pixi.toml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ cwd = "humble_ws"
5959
[tasks.rosbag2_storage_mcap]
6060
cmd = """
6161
(test -d src/rosbag2_storage_mcap || git clone https://github.com/ros-tooling/rosbag2_storage_mcap.git src/rosbag2_storage_mcap)
62-
&& colcon build --packages-select rosbag2_storage_mcap --cmake-args -DCMAKE_BUILD_TYPE=Release
62+
&& colcon build --packages-select mcap_vendor rosbag2_storage_mcap_testdata rosbag2_storage_mcap --cmake-args -DCMAKE_BUILD_TYPE=Release
6363
"""
6464
depends_on = ["ws"]
6565
cwd = "humble_ws"
@@ -104,11 +104,6 @@ depends_on = ["build", "go2_example_data", "go2_ros2_sdk", "rosbag2_storage_mcap
104104
cwd = "humble_ws"
105105

106106
# Install Rerun and URDF loader manually via pip3, this should be replaced with direct pypi dependencies in the future.
107-
# Wait for direct branch and find-links support in pixi. Otherwise updating to a prerelease becomes a hassle.
108-
# See:
109-
# https://pixi.sh/latest/reference/configuration/#pypi-dependencies-beta-feature
110-
# https://github.com/prefix-dev/pixi/issues/1163
111-
112107
[tasks.rerun_viewer]
113108
cmd = "pip install rerun-sdk==0.16"
114109

rerun_bridge/src/rerun_bridge/visualizer_node.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ void RerunLoggerNode::_read_yaml_config(std::string yaml_path) {
203203
extra_pinhole["image_from_camera"][5].as<float>(),
204204
extra_pinhole["image_from_camera"][8].as<float>(),
205205
};
206-
_rec.log_timeless(
206+
_rec.log_static(
207207
extra_pinhole["entity_path"].as<std::string>(),
208208
rerun::Pinhole(image_from_camera)
209209
.with_resolution(

0 commit comments

Comments
 (0)