Making wp_signon errors visible to users. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signon errors can occur in situations beyond just those generated from RC. We should be carrying those users forward to the UI.
ashleyfae
requested changes
Aug 26, 2019
| ) ); | ||
|
|
||
| wp_safe_redirect( esc_url_raw( $redirect ) ); | ||
| if( is_wp_error($wp_signon_result) ){ |
Member
There was a problem hiding this comment.
Can you please add spaces around the $wp_signon_result variable?
| if( is_wp_error($wp_signon_result) ){ | ||
| rc_errors()->add( 'wp_signin_error' , $wp_signon_result->get_error_message(), 'login' ); | ||
| $errors = rc_errors()->get_error_messages(); | ||
| }else{ |
Member
There was a problem hiding this comment.
Can you add a space between } and else ?
|
|
||
| wp_safe_redirect( esc_url_raw( $redirect ) ); | ||
| if( is_wp_error($wp_signon_result) ){ | ||
| rc_errors()->add( 'wp_signin_error' , $wp_signon_result->get_error_message(), 'login' ); |
Member
There was a problem hiding this comment.
Let's set the error code to $wp_signon_result->get_error_code() instead of wp_signin_error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signon errors can occur in situations beyond just those generated from RC. We should be carrying those users forward to the UI.