Skip to content

Commit 6b5034b

Browse files
lihongyan1jan--fdependabot[bot]PeterYurkovichfalox
authored
sync code changes from main to release-1.3 (#918)
* fix: fix linter issues and add CI check for linter changes (#887) Since we call `golang-lint --fix` we should check if the linter has fixed anything. Signed-off-by: Jan Fajerski <[email protected]> * build(deps): bump github.com/grafana/tempo-operator (#915) Bumps [github.com/grafana/tempo-operator](https://github.com/grafana/tempo-operator) from 0.16.0 to 0.18.0. - [Release notes](https://github.com/grafana/tempo-operator/releases) - [Changelog](https://github.com/grafana/tempo-operator/blob/main/CHANGELOG.md) - [Commits](grafana/tempo-operator@v0.16.0...v0.18.0) --- updated-dependencies: - dependency-name: github.com/grafana/tempo-operator dependency-version: 0.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * OU-964: update incidents and TP to GA (#912) * feat: update min version for incident feature to 4.20 * feat: update incidents and tp to GA in matrix * fix: re-enable incidents on 4.19 --------- Co-authored-by: Alberto Falossi <[email protected]> * fix: set 4.19 as GA for incidents (#917) * chore: update korrel8r image to 0.8.4 for COO 1.3 (#908) --------- Signed-off-by: Jan Fajerski <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jan Fajerski <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Yurkovich <[email protected]> Co-authored-by: Alberto Falossi <[email protected]> Co-authored-by: Alan Conway <[email protected]>
1 parent db9ad5c commit 6b5034b

File tree

9 files changed

+60
-19
lines changed

9 files changed

+60
-19
lines changed

‎.github/workflows/pr-checks.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ jobs:
4343
- name: Lint Shell scripts
4444
run: make lint-shell
4545

46+
- name: Check for linter changes
47+
run: git diff --exit-code
48+
4649
generate:
4750
name: Verify generated code
4851
runs-on: ubuntu-latest

‎Makefile‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ lint: lint-golang lint-shell
3131
lint-golang: $(GOLANGCI_LINT)
3232
$(GOLANGCI_LINT) run ./... --fix
3333

34-
# TODO(simonpasquier): remove this after #629 merges.
35-
.PHONY: lint-jsonnet fmt-jsonnet
36-
lint-jsonnet fmt-jsonnet:
37-
3834
.PHONY: lint-shell
3935
lint-shell: $(SHELLCHECK)
4036
find -name "*.sh" -print0 | xargs --null $(SHELLCHECK)

‎cmd/operator/main.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ var defaultImages = map[string]string{
4646
"ui-distributed-tracing": "quay.io/openshift-observability-ui/distributed-tracing-console-plugin:v1.0.1",
4747
"ui-logging-pf4": "quay.io/openshift-observability-ui/logging-view-plugin:v6.0.1",
4848
"ui-logging": "quay.io/openshift-observability-ui/logging-view-plugin:v6.1.2",
49-
"korrel8r": "quay.io/korrel8r/korrel8r:release-coo-1.2",
49+
"korrel8r": "quay.io/korrel8r/korrel8r:0.8.4",
5050
"health-analyzer": "quay.io/openshiftanalytics/cluster-health-analyzer:v1.0.0",
5151
"ui-monitoring-pf5": "quay.io/openshift-observability-ui/monitoring-console-plugin:v0.4.3",
5252
"ui-monitoring": "quay.io/openshift-observability-ui/monitoring-console-plugin:v0.5.2",

‎docs/user-guides/observability-ui-plugins.md‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ The plugin adds monitoring related UI features to the OpenShift web console, rel
146146

147147
To deploy ACM related features the `acm-alerting` configuration must be enabled. In the UIPlugin Custom Resource (CR) you must pass the Alertmanager and ThanosQuerier Service endpoint (e.g. `https://alertmanager.open-cluster-management-observability.svc:9095` and `https://rbac-query-proxy.open-cluster-management-observability.svc:8443`). See the example in the next section `Plugin Creation.`
148148

149-
To deploy the Incidents feature, the `incidents` configuration must be enabled. See the example in the next section, `Plugin Creation.`
149+
To deploy the Incidents feature, the `incidents` configuration must be enabled. See the example in the next section, `Plugin Creation.`
150150

151-
To deploy the Perses dashboard feature, the `perses-dashboards` configuration must be enabled. In the UIPlugin CR, you can optionally pass the service name and namespace of your Perses instance (e.g., `serviceName: perses-api-http` and `namespace: perses`). If these fields are left blank and `spec.monitoring.perses.enabled: true`, then default values will be assigned. These default values are `serviceName: perses-api-http` and `namespace: perses`. See the example in the next section, `Plugin Creation.`
151+
To deploy the Perses dashboard feature, the `perses-dashboards` configuration must be enabled. In the UIPlugin CR, you can optionally pass the service name and namespace of your Perses instance (e.g., `serviceName: perses-api-http` and `namespace: perses`). If these fields are left blank and `spec.monitoring.perses.enabled: true`, then default values will be assigned. These default values are `serviceName: perses-api-http` and `namespace: perses`. See the example in the next section, `Plugin Creation.`
152152
Besides, when `spec.monitoring.perses.enabled: true`, Accelerator Perses dashboard and Accelerator Perses datasource are both created.
153153

154154
ObO/COO operator creates the following roles:
@@ -219,7 +219,7 @@ roleRef:
219219
kind: ClusterRole
220220
name: persesdatasource-editor-role
221221
```
222-
222+
223223
Other pages which are typically distributed with the monitoring-plugin, such as `Admin > Observe > Dashboards`, are only available in the monitoring-plugin when deployed through [CMO](https://github.com/openshift/cluster-monitoring-operator).
224224

225225
#### Plugin Creation
@@ -248,11 +248,11 @@ spec:
248248

249249
#### Feature List
250250

251-
| __Feature__ | __Description__ | __Support Level__ |
252-
| ------------------- | ------------------------------------------------------------------------------------------------------------------------ | ----------------- |
253-
| `acm-alerting` | Adds alerting UI to multi-cluster view. Configures proxies to connect with any alertmanager and thanos-querier. | Dev Preview |
254-
| `incidents` | Adds incidents UI to `Observe` section of OpenShift Console Platform. Deploys the [Cluster Health Analyzer](https://github.com/openshift/cluster-health-analyzer) and configures proxies in the plugin to connect with it. | Tech Preview |
255-
| `perses-dashboards` | Adds perses UI to `Observe` section of OpenShift Console Platform. Configures proxies to connect with a Perses instance. Installs Accelerator Perses Dashboard and Accelerator Perses Datasource. See details [here](./perses-dashboards.md) | Dev Preview |
251+
| __Feature__ | __Description__ | __Support Level__ |
252+
| ------------------- | ------------------------------------------------------------------------------------------------------------------------ | ----------------- |
253+
| `acm-alerting` | Adds alerting UI to multi-cluster view. Configures proxies to connect with any alertmanager and thanos-querier. | Dev Preview |
254+
| `incidents` | Adds incidents UI to `Observe` section of OpenShift Console Platform. Deploys the [Cluster Health Analyzer](https://github.com/openshift/cluster-health-analyzer) and configures proxies in the plugin to connect with it. | General Availability |
255+
| `perses-dashboards` | Adds perses UI to `Observe` section of OpenShift Console Platform. Configures proxies to connect with a Perses instance. Installs Accelerator Perses Dashboard and Accelerator Perses Datasource. See details [here](./perses-dashboards.md) | Dev Preview |
256256

257257

258258
#### Feature Matrix
@@ -261,4 +261,5 @@ spec:
261261
| --------------- | ------------------- | --------------------------------- |
262262
| 1.0.0+ | 4.14+ | `acm-alerting` |
263263
| 1.1.0+ | 4.15+ | `acm-alerting, perses-dashboards` |
264-
| 1.2.0+ | 4.19+ | `acm-alerting, perses-dashboards, incidents` |
264+
| 1.2.0 | 4.19+ | `acm-alerting, perses-dashboards, incidents (Tech Preview)` |
265+
| 1.3.0+ | 4.19+ | `acm-alerting, perses-dashboards, incidents (General Availability)` |

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ require (
77
github.com/go-logr/logr v1.4.3
88
github.com/goccy/go-yaml v1.18.0
99
github.com/google/go-cmp v0.7.0
10-
github.com/grafana/tempo-operator v0.16.0
10+
github.com/grafana/tempo-operator v0.18.0
1111
github.com/open-telemetry/opentelemetry-operator v0.135.0
1212
github.com/openshift/api v3.9.0+incompatible // PINNED: newer versions remove console/v1alpha1 API needed for OpenShift <4.17 compatibility
1313
github.com/operator-framework/api v0.34.0

‎go.sum‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,8 @@ github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 h1:JeSE6pjso5T
253253
github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674/go.mod h1:r4w70xmWCQKmi1ONH4KIaBptdivuRPyosB9RmPlGEwA=
254254
github.com/grafana/regexp v0.0.0-20250905093917-f7b3be9d1853 h1:cLN4IBkmkYZNnk7EAJ0BHIethd+J6LqxFNw5mSiI2bM=
255255
github.com/grafana/regexp v0.0.0-20250905093917-f7b3be9d1853/go.mod h1:+JKpmjMGhpgPL+rXZ5nsZieVzvarn86asRlBg4uNGnk=
256-
github.com/grafana/tempo-operator v0.16.0 h1:/HLVmdC1mnEZMFjWCo1GJWS3DxzTdfjvyXAvq/dXURU=
257-
github.com/grafana/tempo-operator v0.16.0/go.mod h1:h3hQBqqiohdYhqltyj0DqLtkAbvEnkwo9Lp323zl3Bo=
256+
github.com/grafana/tempo-operator v0.18.0 h1:ihXddVx2/I9EbMTkPBnbnN0Uc19sjxAFDx2BqublXqQ=
257+
github.com/grafana/tempo-operator v0.18.0/go.mod h1:xt66ENn9wlMOqj0OAtoiNm3w+JIah4LAeX/XZgdsLsU=
258258
github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.2 h1:8Tjv8EJ+pM1xP8mK6egEbD1OgnVTyacbefKhmbLhIhU=
259259
github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.2/go.mod h1:pkJQ2tZHJ0aFOVEEot6oZmaVEZcRme73eIFmhiVuRWs=
260260
github.com/hashicorp/consul/api v1.32.0 h1:5wp5u780Gri7c4OedGEPzmlUEzi0g2KyiPphSr6zjVg=

‎pkg/controllers/uiplugin/compatibility_matrix.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ var compatibilityMatrix = []CompatibilityEntry{
5050
MinClusterVersion: "v4.16",
5151
MaxClusterVersion: "",
5252
ImageKey: "ui-troubleshooting-panel",
53-
SupportLevel: TechPreview,
53+
SupportLevel: GeneralAvailability,
5454
Features: []string{},
5555
},
5656
{
@@ -145,7 +145,7 @@ var compatibilityMatrix = []CompatibilityEntry{
145145
MinClusterVersion: "v4.19",
146146
MaxClusterVersion: "",
147147
ImageKey: "ui-monitoring",
148-
SupportLevel: TechPreview,
148+
SupportLevel: GeneralAvailability,
149149
// feature flags for montioring are dynamically injected
150150
// based on the cluster version and and UIPlugin CR configurations
151151
Features: []string{},

‎pkg/controllers/uiplugin/compatibility_matrix_test.go‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,24 +50,28 @@ func TestLookupImageAndFeatures(t *testing.T) {
5050
expectedKey string
5151
expectedErr error
5252
expectedFeatures []string
53+
supportLevel SupportLevel
5354
}{
5455
{
5556
pluginType: uiv1alpha1.TypeDashboards,
5657
clusterVersion: "4.10",
5758
expectedKey: "",
5859
expectedErr: fmt.Errorf("dynamic plugins not supported before 4.11"),
60+
supportLevel: "",
5961
},
6062
{
6163
pluginType: uiv1alpha1.TypeDashboards,
6264
clusterVersion: "4.11",
6365
expectedKey: "ui-dashboards",
6466
expectedErr: nil,
67+
supportLevel: DevPreview,
6568
},
6669
{
6770
pluginType: uiv1alpha1.TypeDashboards,
6871
clusterVersion: "4.24.0-0.nightly-2024-03-11-200348",
6972
expectedKey: "ui-dashboards",
7073
expectedErr: nil,
74+
supportLevel: DevPreview,
7175
},
7276
{
7377
pluginType: uiv1alpha1.TypeLogging,
@@ -78,6 +82,7 @@ func TestLookupImageAndFeatures(t *testing.T) {
7882
"dev-console",
7983
"alerts",
8084
},
85+
supportLevel: GeneralAvailability,
8186
},
8287
{
8388
pluginType: uiv1alpha1.TypeLogging,
@@ -88,6 +93,7 @@ func TestLookupImageAndFeatures(t *testing.T) {
8893
"dev-console",
8994
"alerts",
9095
},
96+
supportLevel: GeneralAvailability,
9197
},
9298
{
9399
pluginType: uiv1alpha1.TypeLogging,
@@ -99,6 +105,7 @@ func TestLookupImageAndFeatures(t *testing.T) {
99105
"alerts",
100106
"dev-alerts",
101107
},
108+
supportLevel: GeneralAvailability,
102109
},
103110
{
104111
pluginType: uiv1alpha1.TypeLogging,
@@ -110,6 +117,7 @@ func TestLookupImageAndFeatures(t *testing.T) {
110117
"alerts",
111118
"dev-alerts",
112119
},
120+
supportLevel: GeneralAvailability,
113121
},
114122
{
115123
pluginType: uiv1alpha1.TypeLogging,
@@ -121,6 +129,7 @@ func TestLookupImageAndFeatures(t *testing.T) {
121129
"alerts",
122130
"dev-alerts",
123131
},
132+
supportLevel: GeneralAvailability,
124133
},
125134
{
126135
pluginType: uiv1alpha1.TypeLogging,
@@ -132,6 +141,7 @@ func TestLookupImageAndFeatures(t *testing.T) {
132141
"alerts",
133142
"dev-alerts",
134143
},
144+
supportLevel: GeneralAvailability,
135145
},
136146
{
137147
pluginType: uiv1alpha1.TypeLogging,
@@ -143,6 +153,7 @@ func TestLookupImageAndFeatures(t *testing.T) {
143153
"alerts",
144154
"dev-alerts",
145155
},
156+
supportLevel: GeneralAvailability,
146157
},
147158
{
148159
pluginType: uiv1alpha1.TypeLogging,
@@ -154,12 +165,14 @@ func TestLookupImageAndFeatures(t *testing.T) {
154165
"alerts",
155166
"dev-alerts",
156167
},
168+
supportLevel: GeneralAvailability,
157169
},
158170
{
159171
pluginType: uiv1alpha1.TypeLogging,
160172
clusterVersion: "4.11",
161173
expectedKey: "ui-logging-pf4",
162174
expectedErr: nil,
175+
supportLevel: GeneralAvailability,
163176
},
164177
{
165178
pluginType: uiv1alpha1.TypeTroubleshootingPanel,
@@ -168,124 +181,144 @@ func TestLookupImageAndFeatures(t *testing.T) {
168181
clusterVersion: "4.15",
169182
expectedKey: "",
170183
expectedErr: fmt.Errorf("plugin %q: no compatible image found for cluster version %q", uiv1alpha1.TypeTroubleshootingPanel, "v4.15"),
184+
supportLevel: GeneralAvailability,
171185
},
172186
{
173187
pluginType: uiv1alpha1.TypeTroubleshootingPanel,
174188
clusterVersion: "4.16",
175189
expectedKey: "ui-troubleshooting-panel",
176190
expectedErr: nil,
191+
supportLevel: GeneralAvailability,
177192
},
178193
{
179194
pluginType: uiv1alpha1.TypeTroubleshootingPanel,
180195
clusterVersion: "4.24.0-0.nightly-2024-03-11-200348",
181196
expectedKey: "ui-troubleshooting-panel",
182197
expectedErr: nil,
198+
supportLevel: GeneralAvailability,
183199
},
184200
{
185201
pluginType: uiv1alpha1.TypeDistributedTracing,
186202
clusterVersion: "4.10",
187203
expectedKey: "",
188204
expectedErr: fmt.Errorf("dynamic plugins not supported before 4.11"),
205+
supportLevel: "",
189206
},
190207
{
191208
pluginType: uiv1alpha1.TypeDistributedTracing,
192209
clusterVersion: "4.11",
193210
expectedKey: "ui-distributed-tracing-pf4",
194211
expectedErr: nil,
212+
supportLevel: GeneralAvailability,
195213
},
196214
{
197215
pluginType: uiv1alpha1.TypeDistributedTracing,
198216
clusterVersion: "4.14",
199217
expectedKey: "ui-distributed-tracing-pf4",
200218
expectedErr: nil,
219+
supportLevel: GeneralAvailability,
201220
},
202221
{
203222
pluginType: uiv1alpha1.TypeDistributedTracing,
204223
clusterVersion: "4.15",
205224
expectedKey: "ui-distributed-tracing-pf5",
206225
expectedErr: nil,
226+
supportLevel: GeneralAvailability,
207227
},
208228
{
209229
pluginType: uiv1alpha1.TypeDistributedTracing,
210230
clusterVersion: "v4.15.0-0.nightly-2024-06-06-064349",
211231
expectedKey: "ui-distributed-tracing-pf5",
212232
expectedErr: nil,
233+
supportLevel: GeneralAvailability,
213234
},
214235
{
215236
pluginType: uiv1alpha1.TypeDistributedTracing,
216237
clusterVersion: "v4.15.46",
217238
expectedKey: "ui-distributed-tracing-pf5",
218239
expectedErr: nil,
240+
supportLevel: GeneralAvailability,
219241
},
220242
{
221243
pluginType: uiv1alpha1.TypeDistributedTracing,
222244
clusterVersion: "4.18",
223245
expectedKey: "ui-distributed-tracing-pf5",
224246
expectedErr: nil,
247+
supportLevel: GeneralAvailability,
225248
},
226249
{
227250
pluginType: uiv1alpha1.TypeDistributedTracing,
228251
clusterVersion: "4.19",
229252
expectedKey: "ui-distributed-tracing",
230253
expectedErr: nil,
254+
supportLevel: GeneralAvailability,
231255
},
232256
{
233257
pluginType: uiv1alpha1.TypeDistributedTracing,
234258
clusterVersion: "4.24.0-0.nightly-2024-03-11-200348",
235259
expectedKey: "ui-distributed-tracing",
236260
expectedErr: nil,
261+
supportLevel: GeneralAvailability,
237262
},
238263
{
239264
pluginType: uiv1alpha1.TypeDistributedTracing,
240265
clusterVersion: "4.16.0-rc.3",
241266
expectedKey: "ui-distributed-tracing-pf5",
242267
expectedErr: nil,
268+
supportLevel: GeneralAvailability,
243269
},
244270
{
245271
pluginType: "non-existent-plugin",
246272
clusterVersion: "4.24.0-0.nightly-2024-03-11-200348",
247273
expectedKey: "",
248274
expectedErr: fmt.Errorf(`plugin "non-existent-plugin": no compatible image found for cluster version "v4.24.0-0.nightly-2024-03-11-200348"`),
275+
supportLevel: "",
249276
},
250277
{
251278
pluginType: uiv1alpha1.TypeTroubleshootingPanel,
252279
clusterVersion: "v4.16.0-0.nightly-2024-06-06-064349",
253280
expectedKey: "ui-troubleshooting-panel",
254281
expectedErr: nil,
282+
supportLevel: GeneralAvailability,
255283
},
256284
{
257285
pluginType: uiv1alpha1.TypeMonitoring,
258286
clusterVersion: "v4.14",
259287
expectedKey: "ui-monitoring",
260288
expectedErr: fmt.Errorf("plugin %q: no compatible image found for cluster version %q", uiv1alpha1.TypeMonitoring, "v4.14"),
289+
supportLevel: TechPreview,
261290
},
262291
{
263292
pluginType: uiv1alpha1.TypeMonitoring,
264293
clusterVersion: "v4.15",
265294
expectedKey: "ui-monitoring-pf5",
266295
expectedFeatures: []string{},
267296
expectedErr: nil,
297+
supportLevel: TechPreview,
268298
},
269299
{
270300
pluginType: uiv1alpha1.TypeMonitoring,
271301
clusterVersion: "v4.15.0-0.nightly-2024-06-06-064349",
272302
expectedKey: "ui-monitoring-pf5",
273303
expectedFeatures: []string{},
274304
expectedErr: nil,
305+
supportLevel: TechPreview,
275306
},
276307
{
277308
pluginType: uiv1alpha1.TypeMonitoring,
278309
clusterVersion: "v4.19",
279310
expectedKey: "ui-monitoring",
280311
expectedFeatures: []string{},
281312
expectedErr: nil,
313+
supportLevel: GeneralAvailability,
282314
},
283315
{
284316
pluginType: uiv1alpha1.TypeMonitoring,
285317
clusterVersion: "v4.19.0-0.nightly-2024-06-06-064349",
286318
expectedKey: "ui-monitoring",
287319
expectedFeatures: []string{},
288320
expectedErr: nil,
321+
supportLevel: GeneralAvailability,
289322
},
290323
} {
291324
t.Run(fmt.Sprintf("%s/%s", tc.pluginType, tc.clusterVersion), func(t *testing.T) {
@@ -301,6 +334,8 @@ func TestLookupImageAndFeatures(t *testing.T) {
301334
t.Logf("%s == %s", tc.expectedKey, info.ImageKey)
302335
assert.Equal(t, tc.expectedKey, info.ImageKey)
303336

337+
assert.Equal(t, tc.supportLevel, info.SupportLevel)
338+
304339
if tc.expectedFeatures != nil {
305340
assert.DeepEqual(t, tc.expectedFeatures, info.Features)
306341
}

‎pkg/controllers/uiplugin/monitoring_test.go‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -485,6 +485,12 @@ func TestCreateMonitoringPluginInfo(t *testing.T) {
485485

486486
t.Run("Test validateIncidentsConfig() with valid and invalid clusterVersion formats", func(t *testing.T) {
487487
// should not throw an error because all these are valid formats for clusterVersion
488+
assert.Assert(t, validateIncidentsConfig(pluginConfigIncidents.Spec.Monitoring, "v4.21.0-0.nightly-2024-06-06-064349") == true)
489+
assert.Assert(t, validateIncidentsConfig(pluginConfigIncidents.Spec.Monitoring, "4.21.0-0.nightly-2024-06-06-064349") == true)
490+
assert.Assert(t, validateIncidentsConfig(pluginConfigIncidents.Spec.Monitoring, "v4.21") == true)
491+
assert.Assert(t, validateIncidentsConfig(pluginConfigIncidents.Spec.Monitoring, "v4.21.0") == true)
492+
assert.Assert(t, validateIncidentsConfig(pluginConfigIncidents.Spec.Monitoring, "4.21.0") == true)
493+
488494
assert.Assert(t, validateIncidentsConfig(pluginConfigIncidents.Spec.Monitoring, "v4.20.0-0.nightly-2024-06-06-064349") == true)
489495
assert.Assert(t, validateIncidentsConfig(pluginConfigIncidents.Spec.Monitoring, "4.20.0-0.nightly-2024-06-06-064349") == true)
490496
assert.Assert(t, validateIncidentsConfig(pluginConfigIncidents.Spec.Monitoring, "v4.20") == true)

0 commit comments

Comments
 (0)