refactor(utils): optimize process.exec by adding options for output control

Author: ribeirogab

package.json

@@ -1,6 +1,6 @@
 {
   "name": "commitfy",
-  "version": "0.0.12",
+  "version": "0.0.13",
   "main": "lib/index.js",
   "repository": "https://github.com/ribeirogab/commitfy.git",
   "author": "ribeirogab <[email protected]>",

src/commands/generate-commit.ts

@@ -29,7 +29,9 @@ export class GenerateCommit {
       process.exit(0);
     }
 
-    const diff = await this.processUtils.exec('git diff --cached');
+    const diff = await this.processUtils.exec('git diff --cached', {
+      showStdout: false,
+    });
 
     if (!diff) {
       console.error(`${this.appUtils.name}: no changes to commit.`);
@@ -57,7 +59,9 @@ export class GenerateCommit {
       return this.execute();
     }
 
-    await this.processUtils.exec(`git commit -m "${response}"`);
+    await this.processUtils.exec(`git commit -m "${response}"`, {
+      showStdout: true,
+    });
 
     process.exit(0);
   }

src/interfaces/utils/process.utils.ts

@@ -1,3 +1,7 @@
+export type ProcessUtilsExecOptions = {
+  showStdout: boolean;
+};
+
 export interface ProcessUtils {
-  exec(command: string): Promise<string>;
+  exec(command: string, options?: ProcessUtilsExecOptions): Promise<string>;
 }

src/utils/process.utils.ts

@@ -2,33 +2,48 @@ import { exec } from 'node:child_process';
 
 import type {
   AppUtils,
+  ProcessUtilsExecOptions,
   ProcessUtils as ProcessUtilsInterface,
 } from '../interfaces';
 
 export class ProcessUtils implements ProcessUtilsInterface {
   constructor(private readonly appUtils: AppUtils) {}
 
-  public async exec(command: string): Promise<string> {
+  public async exec(
+    command: string,
+    options: ProcessUtilsExecOptions = { showStdout: false },
+  ): Promise<string> {
     return new Promise((resolve, reject) => {
-      exec(command, (error, stdout, stderr) => {
-        if (error) {
-          this.appUtils.logger.error(
-            `Error executing command '${command}'\n`,
-            error,
-          );
-
-          reject(stderr);
-        } else {
-          resolve(stdout);
+      const childProcess = exec(command);
+      let stdout = '';
+
+      childProcess.stdout.on('data', (data) => {
+        if (options.showStdout) {
+          process.stdout.write(data);
         }
 
-        process.stdout.on('data', (data) => {
-          console.log(data.toString());
-        });
+        stdout += data.toString();
+      });
+
+      childProcess.stderr.on('data', (data) => {
+        process.stderr.write(data);
+      });
+
+      childProcess.on('error', (error) => {
+        this.appUtils.logger.error(
+          `Error executing command '${command}'\n`,
+          error,
+        );
+
+        reject(error);
+      });
 
-        process.stderr.on('data', (data) => {
-          console.error(data.toString());
-        });
+      childProcess.on('close', (code) => {
+        if (code !== 0) {
+          reject(`Command failed with exit code ${code}`);
+        } else {
+          resolve(stdout);
+        }
       });
     });
   }