Only start setting flag after 24 hours running. Alert user to give them op to rollback

Author: 0xfornax

rocketpool/node/node.go

@@ -40,7 +40,6 @@ const (
 	DownloadRewardsTreesColor      = color.FgGreen
 	MetricsColor                   = color.FgHiYellow
 	ManageFeeRecipientColor        = color.FgHiCyan
-	ReduceBondAmountColor          = color.FgHiBlue
 	DefendPdaoPropsColor           = color.FgYellow
 	VerifyPdaoPropsColor           = color.FgYellow
 	DistributeMinipoolsColor       = color.FgHiGreen

rocketpool/node/set-latest-delegate.go

@@ -3,6 +3,7 @@ package node
 import (
 	"fmt"
 	"math/big"
+	"time"
 
 	"github.com/docker/docker/client"
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
@@ -11,6 +12,7 @@ import (
 	"github.com/rocket-pool/smartnode/bindings/rocketpool"
 	"github.com/rocket-pool/smartnode/bindings/utils/eth"
 	rpstate "github.com/rocket-pool/smartnode/bindings/utils/state"
+	"github.com/rocket-pool/smartnode/shared/services/alerting"
 	"github.com/urfave/cli/v3"
 
 	"github.com/rocket-pool/smartnode/shared/services"
@@ -36,6 +38,7 @@ type setUseLatestDelegate struct {
 	maxFee         *big.Int
 	maxPriorityFee *big.Int
 	gasLimit       uint64
+	startTime      time.Time
 }
 
 // Create distribute minipools task
@@ -84,6 +87,8 @@ func newSetUseLatestDelegate(c *cli.Command, logger log.ColorLogger) (*setUseLat
 
 	gasThreshold := cfg.Smartnode.AutoTxGasThreshold.Value.(float64)
 
+	startTime := time.Now()
+
 	// Return task
 	return &setUseLatestDelegate{
 		c:              c,
@@ -97,6 +102,7 @@ func newSetUseLatestDelegate(c *cli.Command, logger log.ColorLogger) (*setUseLat
 		maxFee:         maxFee,
 		maxPriorityFee: priorityFee,
 		gasLimit:       0,
+		startTime:      startTime,
 	}, nil
 
 }
@@ -129,6 +135,13 @@ func (t *setUseLatestDelegate) run(state *state.NetworkState) error {
 	// Log
 	t.log.Printlnf("%d minipool(s) can have their use latest delegate set...", len(minipools))
 
+	// If the node has been running for less than 24 hours, alert the user. After that, set the flag for the minipools.
+	if time.Since(t.startTime) < 24*time.Hour {
+		t.log.Println("Alerting user they have minipools that can have the 'use latest delegate' flag set...")
+		alerting.AlertMinipoolUseLatestDelegateSet(t.cfg)
+		return nil
+	}
+
 	// Set use latest delegate for minipools
 	successCount := 0
 	for _, mpd := range minipools {

shared/services/alerting/alerting.go

@@ -192,6 +192,19 @@ func getAlertSettingsForEvent(succeeded bool) (strfmt.DateTime, Severity, string
 	return endsAt, severity, succeededOrFailedText
 }
 
+// Sends an alert when the node has minipools that can have their use latest delegate set.
+func AlertMinipoolUseLatestDelegateSet(cfg *config.RocketPoolConfig) error {
+	alert := createAlert(
+		"MinipoolUseLatestDelegateSet",
+		"Minipools can have the 'use latest delegate' flag set",
+		"Starting with v1.19.1, the Smart Node includes an automatic task that will set all legacy minipools to use the latest delegate contract. For Megapools, node operators continue to have 120 days to choose when to upgrade after a new delegate is released. If you do not wish to opt into using the latest delegate contract on your minipools, you should rollback to v1.19.0.",
+		SeverityWarning,
+		strfmt.DateTime(time.Now().Add(DefaultEndsAtDurationForSeverityInfo)),
+		nil,
+	)
+	return sendAlert(alert, cfg)
+}
+
 // Sends an alert when the execution client's P2P port is not accessible from the internet.
 func AlertEth1P2PPortNotOpen(cfg *config.RocketPoolConfig, port uint16) error {
 	alert := createAlert(