Skip to content

Commit 043d2b5

Browse files
authored
Merge pull request #1046 from lodekeeper/feat/lodestar-quic-support
feat: add QUIC transport support for Lodestar
2 parents 65bf4db + 7479373 commit 043d2b5

File tree

4 files changed

+24
-2
lines changed

4 files changed

+24
-2
lines changed

shared/services/config/lodestar-config.go

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import (
55
)
66

77
const (
8-
lodestarTagTest string = "chainsafe/lodestar:v1.40.0"
9-
lodestarTagProd string = "chainsafe/lodestar:v1.40.0"
8+
lodestarTagTest string = "chainsafe/lodestar:v1.41.0"
9+
lodestarTagProd string = "chainsafe/lodestar:v1.41.0"
1010
defaultLodestarMaxPeers uint16 = 200
1111
)
1212

@@ -23,6 +23,9 @@ type LodestarConfig struct {
2323
// The Docker Hub tag for Lighthouse
2424
ContainerTag config.Parameter `yaml:"containerTag,omitempty"`
2525

26+
// The port to use for gossip traffic using the QUIC protocol
27+
P2pQuicPort config.Parameter `yaml:"p2pQuicPort,omitempty"`
28+
2629
// Custom command line flags for the BN
2730
AdditionalBnFlags config.Parameter `yaml:"additionalBnFlags,omitempty"`
2831

@@ -49,6 +52,17 @@ func NewLodestarConfig(cfg *RocketPoolConfig) *LodestarConfig {
4952
OverwriteOnUpgrade: false,
5053
},
5154

55+
P2pQuicPort: config.Parameter{
56+
ID: P2pQuicPortID,
57+
Name: "P2P QUIC Port",
58+
Description: "The port to use for P2P (blockchain) traffic using the QUIC protocol.",
59+
Type: config.ParameterType_Uint16,
60+
Default: map[config.Network]interface{}{config.Network_All: defaultP2pQuicPort},
61+
AffectsContainers: []config.ContainerID{config.ContainerID_Eth2},
62+
CanBeBlank: false,
63+
OverwriteOnUpgrade: false,
64+
},
65+
5266
ContainerTag: config.Parameter{
5367
ID: "containerTag",
5468
Name: "Container Tag",
@@ -92,6 +106,7 @@ func NewLodestarConfig(cfg *RocketPoolConfig) *LodestarConfig {
92106
func (cfg *LodestarConfig) GetParameters() []*config.Parameter {
93107
return []*config.Parameter{
94108
&cfg.MaxPeers,
109+
&cfg.P2pQuicPort,
95110
&cfg.ContainerTag,
96111
&cfg.AdditionalBnFlags,
97112
&cfg.AdditionalVcFlags,

shared/services/config/rocket-pool-config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1681,6 +1681,7 @@ func (cfg *RocketPoolConfig) Validate() []string {
16811681
portMap, errors = addAndCheckForDuplicate(portMap, cfg.Prometheus.Port, errors)
16821682
portMap, errors = addAndCheckForDuplicate(portMap, cfg.Alertmanager.Port, errors)
16831683
_, errors = addAndCheckForDuplicate(portMap, cfg.Lighthouse.P2pQuicPort, errors)
1684+
_, errors = addAndCheckForDuplicate(portMap, cfg.Lodestar.P2pQuicPort, errors)
16841685

16851686
return errors
16861687
}

shared/services/rocketpool/assets/install/scripts/start-bn.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ if [ "$CC_CLIENT" = "lodestar" ]; then
111111
--dataDir /ethclient/lodestar \
112112
--serveHistoricalState \
113113
--port $BN_P2P_PORT \
114+
--quic \
115+
--quicPort ${BN_P2P_QUIC_PORT:-8001} \
114116
--execution.urls $EC_ENGINE_ENDPOINT \
115117
--rest \
116118
--rest.address 0.0.0.0 \

shared/services/rocketpool/assets/install/templates/eth2.tmpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ services:
3535
- "{{.Lighthouse.P2pQuicPort}}:{{.Lighthouse.P2pQuicPort}}/udp"
3636
{{- else if eq .ConsensusClient.String "prysm"}}
3737
- "{{.Prysm.P2pQuicPort}}:{{.Prysm.P2pQuicPort}}/udp"
38+
{{- else if eq .ConsensusClient.String "lodestar"}}
39+
- "{{.Lodestar.P2pQuicPort}}:{{.Lodestar.P2pQuicPort}}/udp"
3840
{{- end}}
3941
{{- range $entry := .GetBnOpenPorts}}
4042
- "{{$entry}}"
@@ -87,6 +89,8 @@ services:
8789
- NIMBUS_PRUNING_MODE={{.Nimbus.PruningMode}}
8890
{{- else if eq .ConsensusClient.String "lighthouse"}}
8991
- BN_P2P_QUIC_PORT={{.Lighthouse.P2pQuicPort}}
92+
{{- else if eq .ConsensusClient.String "lodestar"}}
93+
- BN_P2P_QUIC_PORT={{.Lodestar.P2pQuicPort}}
9094
{{- end}}
9195
command: "/setup/start-bn.sh"
9296
cap_drop:

0 commit comments

Comments
 (0)