Ability to check for a certain # of characters

[TraGicCode]

I recently worked on a epp template where i needed to generate the following in a configuration file.

Example1

[{
	"Class": "MyNamespace.MyClass",
	"Method": "MyMethod"
},
{
	"Class": "MyNamespace.MyClass2",
	"Method": "MyMethod"
}
]

Example2

[{
	"Class": "MyNamespace.MyClass",
	"Method": "MyMethod"
}
]

It seemed very hard to write a test to actually check if i am rendering commas correctly. For example the first example is an array that contains 1 item and therefore has no commas to separate items since its a 1 item array. The second example on the other hand needs to have a comma rendered between items.

It would be nice to have a feature where you could assert that a certain character appears an expected # of times. This way i could assert my logic of comma seperation is working as i expect it to.

[domcleal]

The existing resource parameter matchers are pretty flexible, e.g. you can test for entire string equality or you can pass a proc in to check the value against anything you like in Ruby, e.g.

it { is_expected.to contain_file('..').with_content(Proc.new { |actual| actual.count(',') }) }

The catalog itself is also accessible through catalogue, and you can either access it directly or use puppetlabs_spec_helper's methods, e.g.

it { expect(param_value(catalogue, 'File', '/etc/example', 'content').count(',')).to eql(1) }

Any value in the catalog can be tested then using regular rspec expectations.

[rodjek]

Eventually, I'd like to move away from the custom matchers to using standard ones, e.g.

describe 'test::class' do
  describe service('bar') do
    its(:ensure) { is_expected.to eq('running') }
  end
end

But this is a little way off (probably the 3.0.0 release), so in the meantime I'd suggest passing a Proc to the matcher like @domcleal suggested.

[rodjek]

@TraGicCode You might be interested in the proposal in #611