Merge pull request #99 from rofinn/rf/cmd-interpolation-fix

Add a specific arg_gen method for AbstractPath

Author: rofinn

Project.toml

@@ -1,7 +1,7 @@
 name = "FilePathsBase"
 uuid = "48062228-2e41-5def-b9a4-89aafe57970f"
 authors = ["Rory Finnegan"]
-version = "0.9.4"
+version = "0.9.5"
 
 [deps]
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"

src/path.jl

@@ -61,6 +61,11 @@ function Base.show(io::IO, fp::AbstractPath)
     get(io, :compact, false) ? print(io, fp) : print(io, "p\"$fp\"")
 end
 
+# Needed for path Cmd interpolation to work correctly.
+# If this isn't defined the fact that a path is iterable will result in each segment being
+# treated as a separate argument.
+Base.arg_gen(fp::AbstractPath) = Base.arg_gen(string(fp))
+
 # Default string constructors for AbstractPath types should fall back to calling `parse`.
 (::Type{T})(str::AbstractString) where {T<:AbstractPath} = parse(T, str)
 

src/test.jl

@@ -15,6 +15,7 @@ ps = PathSet(; symlink=true)
 testsets = [
     test_registration,
     test_show,
+    test_cmd,
     test_parse,
     test_convert,
     test_components,
@@ -68,6 +69,7 @@ module TestPaths
         test,
         test_registration,
         test_show,
+        test_cmd,
         test_parse,
         test_convert,
         test_components,
@@ -200,6 +202,13 @@ module TestPaths
         end
     end
 
+    function test_cmd(ps::PathSet)
+        @testset "cmd" begin
+            str = string(ps.root)
+            @test `echo $str` == `echo $(ps.root)`
+        end
+    end
+
     function test_parse(ps::PathSet{P}) where P <: AbstractPath
         @testset "parsing" begin
             str = string(ps.root)
@@ -895,6 +904,7 @@ module TestPaths
     TESTALL = [
         test_registration,
         test_show,
+        test_cmd,
         test_parse,
         test_convert,
         test_components,

test/runtests.jl

@@ -23,6 +23,7 @@ include("testpkg.jl")
             testsets = [
                 test_registration,
                 test_show,
+                test_cmd,
                 test_parse,
                 test_convert,
                 test_components,

test/system.jl

@@ -4,6 +4,7 @@ ps = PathSet(; symlink=true)
     testsets = [
         test_registration,
         test_show,
+        test_cmd,
         test_parse,
         test_convert,
         test_components,