Improve buffer tests.

Author: rofinn

src/buffer.jl

@@ -72,7 +72,7 @@ end
 #=
 NOTE: We need to define multiple methods because of ambiguity error with base IO methods.
 =#
-function Base.write(buffer::FileBuffer, x::Union{UInt8, Vector{UInt8}})
+function Base.write(buffer::FileBuffer, x::Vector{UInt8})
     iswritable(buffer) || throw(ArgumentError("write failed, FileBuffer is not writeable"))
     write(buffer.io, x)
 end
@@ -82,6 +82,11 @@ function Base.write(buffer::FileBuffer, x::String)
     write(buffer.io, x)
 end
 
+function Base.write(buffer::FileBuffer, x::UInt8)
+    iswritable(buffer) || throw(ArgumentError("write failed, FileBuffer is not writeable"))
+    write(buffer.io, x)
+end
+
 function Base.flush(buffer::FileBuffer)
     if iswritable(buffer)
         seekstart(buffer)

test/buffer.jl

@@ -14,7 +14,12 @@ using FilePathsBase: FileBuffer
             @test !eof(io)
             @test read(p, String) == read(io, String)
             @test eof(io)
-            seekstart(io)
+        finally
+            close(io)
+        end
+
+        io = FileBuffer(p)
+        try
             for b in read(p)
                 @test read(io, UInt8) == b
             end
@@ -50,6 +55,23 @@ using FilePathsBase: FileBuffer
                 finally
                     close(io)
                 end
+
+                rm(p2)
+
+                io = FileBuffer(p2; read=true,write=true)
+                try
+                    write(io, read(p1))
+                    flush(io)
+
+                    seekstart(io)
+                    for b in read(p1)
+                        write(io, b)
+                    end
+                    flush(io)
+                    @test read(p1) == read(p2)
+                finally
+                    close(io)
+                end
             end
         end
     end

test/system.jl

@@ -384,7 +384,6 @@ ps = PathSet(; symlink=true)
                     @test ispath("cpstr")
 
                     # Recursive directory
-                    @show docsdir
                     @test cp(docsdir, p"cpdstpath"; force=true) == p"cpdstpath"
                     @test ispath(p"cpdstpath")
                     @test ispath(p"cpdstpath/src/api.md")