How to fix request failed from extensions

[azharlq]

Hello! I have a Roku project with BrighterScript and BrightScript Language Visual Studio Code extension. But suddenly I got these errors and the extension did not work properly. I have reinstalled the extension and the dependencies on my project but errors are still there. It becomes annoying because the errors and warnings keep appearing every time I type, hover a function/method/variable in a file, and change a working file. Do someone know how to fix this?

[TwitchBronBron]

I'm not entirely sure why it's crashing, but we recently enabled multithreading for the language server, so can you try setting "brightscript.languageServer.enableThreading": false in your settings.json and see if that either fixes the error or at least gives a slightly more helpful error message?

[azharlq]

The errors are gone now after disabling the multithreading setting. Thank you.
As for the error messages, that's all I got. Although I did get one more error message before all of the errors from the screenshot. Not sure if this helps but here it is. This errors are before disabling the multithreading setting.

Error: Worker thread encountered an error: "TypeError: Cannot read properties of undefined (reading 'applyFileChanges')\n    at Object.onRequest (D:\\[PROJECT_NAME]\\node_modules\\.pnpm\\brighterscript@0.69.13\\node_modules\\brighterscript\\dist\\lsp\\worker\\WorkerThreadProjectRunner.js:27:58)\n    at MessagePort.listener (D:\\[PROJECT_NAME]\\node_modules\\.pnpm\\brighterscript@0.69.13\\node_modules\\brighterscript\\dist\\lsp\\worker\\MessageHandler.js:22:136)\n    at [nodejs.internal.kHybridDispatch] (node:internal/event_target:827:20)\n    at MessagePort.<anonymous> (node:internal/per_context/messageport:23:28)"
    at MessageHandler.sendRequest (c:\Users\[USERNAME]\.vscode\extensions\rokucommunity.brightscript-2.58.0\node_modules\brighterscript\dist\lsp\worker\MessageHandler.js:74:19)
    at async WorkerThreadProject.applyFileChanges (c:\Users\[USERNAME]\.vscode\extensions\rokucommunity.brightscript-2.58.0\node_modules\brighterscript\dist\lsp\worker\WorkerThreadProject.js:101:26)
    at async c:\Users\[USERNAME]\.vscode\extensions\rokucommunity.brightscript-2.58.0\node_modules\brighterscript\dist\lsp\ProjectManager.js:103:41
    at async Promise.all (index 0)
    at async ProjectManager.flushDocumentChanges (c:\Users\[USERNAME]\.vscode\extensions\rokucommunity.brightscript-2.58.0\node_modules\brighterscript\dist\lsp\ProjectManager.js:87:27)
    at async DocumentManager.flush (c:\Users\[USERNAME]\.vscode\extensions\rokucommunity.brightscript-2.58.0\node_modules\brighterscript\dist\lsp\DocumentManager.js:75:17)

[TwitchBronBron]

Interesting stuff. I'll definitely look into the errors to see if I can harden up that code at all.

Are you using any BrighterScript plugins in your project by chance? Sometimes those contribute malformed AST which cause issues. (Just curious)

[azharlq]

Now that you mentioned plugins, I have a custom one that imports .env values into a variable. I tried removing it from bsconfig.json, and the errors disappeared when I enabled the multithreading setting.
Maybe I need to update my code. Last time I code this file was a few months ago. Anyway here is the main part of my custom plugin code, in case you're interested.

module.exports = function () {
    const envJson = buildEnvJson()

    /** @type {import('brighterscript').CompilerPlugin} */
    const config = {
        name: 'generatePublicEnvJson',
        beforeFileTranspile: (event) => {
            if (event.file.pkgPath === 'source\\env.bs') {
                event.file.ast.walk(
                    createVisitor({
                        AssignmentStatement: (statement) => {
                            if (statement.name.text === '__ALL_ENVIRONMENTS__') {
                                event.editor.overrideTranspileResult(statement, '__ALL_ENVIRONMENTS__ = ' + JSON.stringify(envJson))
                            }
                        },
                        CommentStatement: (statement) => {
                            event.editor.overrideTranspileResult(statement, '')
                        }
                    }),
                    {
                        walkMode: WalkMode.visitStatementsRecursive,
                    }
                )
            }
        }
    }

    return config
}

function getEnv(key as string) as dynamic
    __ALL_ENVIRONMENTS__ = {}

    return __ALL_ENVIRONMENTS__.lookup(key)
end function

[TwitchBronBron]

Good find! I am curious why this plugin would be causing problems though. The language server doesn't use the transpile events for normal editor events, unless you're using the "preview transpilied code" commands.

Do you think you'd be able to get me a very simple test project with this plugin and some code that reproduces the issue when hovering? That would be very useful in tracking down the proper flows in the brighterscript source code to prevent the crash.